wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-06-29 07:07:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Placement Group] Move PlacementGroup public method to interface. (#13629)

Browse Source
This commit is contained in:
DK.Pino
2021-01-25 20:14:21 +08:00
committed by GitHub
parent b4702de1c2
commit db2c836587
3 changed files with 70 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/test/src/main/java/io/ray/test/PlacementGroupTest.java
+15 -23
View File
@@ -7,7 +7,6 @@ import io.ray.api.placementgroup.PlacementGroup;
import io.ray.api.placementgroup.PlacementGroupState;
import io.ray.api.placementgroup.PlacementStrategy;
import io.ray.runtime.exception.RayException;
import io.ray.runtime.placementgroup.PlacementGroupImpl;
import java.util.List;
import org.testng.Assert;
import org.testng.annotations.Test;
@@ -32,8 +31,7 @@ public class PlacementGroupTest extends BaseTest {
// This test just creates a placement group with one bundle.
// It's not comprehensive to test all placement group test cases.
public void testCreateAndCallActor() {
PlacementGroupImpl placementGroup =
(PlacementGroupImpl) PlacementGroupTestUtils.createSimpleGroup();
PlacementGroup placementGroup = PlacementGroupTestUtils.createSimpleGroup();
Assert.assertTrue(placementGroup.wait(10));
Assert.assertEquals(placementGroup.getName(), "unnamed_group");
@@ -48,22 +46,18 @@ public class PlacementGroupTest extends BaseTest {
@Test(groups = {"cluster"})
public void testGetPlacementGroup() {
PlacementGroupImpl firstPlacementGroup =
(PlacementGroupImpl)
PlacementGroupTestUtils.createNameSpecifiedSimpleGroup(
"CPU", 1, PlacementStrategy.PACK, 1.0, "first_placement_group");
PlacementGroup firstPlacementGroup =
PlacementGroupTestUtils.createNameSpecifiedSimpleGroup(
"CPU", 1, PlacementStrategy.PACK, 1.0, "first_placement_group");
PlacementGroupImpl secondPlacementGroup =
(PlacementGroupImpl)
PlacementGroupTestUtils.createNameSpecifiedSimpleGroup(
"CPU", 1, PlacementStrategy.PACK, 1.0, "second_placement_group");
PlacementGroup secondPlacementGroup =
PlacementGroupTestUtils.createNameSpecifiedSimpleGroup(
"CPU", 1, PlacementStrategy.PACK, 1.0, "second_placement_group");
Assert.assertTrue(firstPlacementGroup.wait(10));
Assert.assertTrue(secondPlacementGroup.wait(10));
PlacementGroupImpl firstPlacementGroupRes =
(PlacementGroupImpl) Ray.getPlacementGroup((firstPlacementGroup).getId());
PlacementGroupImpl secondPlacementGroupRes =
(PlacementGroupImpl) Ray.getPlacementGroup((secondPlacementGroup).getId());
PlacementGroup firstPlacementGroupRes = Ray.getPlacementGroup((firstPlacementGroup).getId());
PlacementGroup secondPlacementGroupRes = Ray.getPlacementGroup((secondPlacementGroup).getId());
Assert.assertNotNull(firstPlacementGroupRes);
Assert.assertNotNull(secondPlacementGroupRes);
@@ -76,9 +70,9 @@ public class PlacementGroupTest extends BaseTest {
List<PlacementGroup> allPlacementGroup = Ray.getAllPlacementGroups();
Assert.assertEquals(allPlacementGroup.size(), 2);
PlacementGroupImpl placementGroupRes = (PlacementGroupImpl) allPlacementGroup.get(0);
PlacementGroup placementGroupRes = allPlacementGroup.get(0);
Assert.assertNotNull(placementGroupRes.getId());
PlacementGroupImpl expectPlacementGroup =
PlacementGroup expectPlacementGroup =
placementGroupRes.getId().equals(firstPlacementGroup.getId())
? firstPlacementGroup
: secondPlacementGroup;
@@ -94,18 +88,16 @@ public class PlacementGroupTest extends BaseTest {
PlacementGroupTestUtils.createNameSpecifiedSimpleGroup(
"CPU", 1, PlacementStrategy.PACK, 1.0, "first_placement_group");
PlacementGroupImpl secondPlacementGroup =
(PlacementGroupImpl)
PlacementGroupTestUtils.createNameSpecifiedSimpleGroup(
"CPU", 1, PlacementStrategy.PACK, 1.0, "second_placement_group");
PlacementGroup secondPlacementGroup =
PlacementGroupTestUtils.createNameSpecifiedSimpleGroup(
"CPU", 1, PlacementStrategy.PACK, 1.0, "second_placement_group");
List<PlacementGroup> allPlacementGroup = Ray.getAllPlacementGroups();
Assert.assertEquals(allPlacementGroup.size(), 2);
Ray.removePlacementGroup(secondPlacementGroup.getId());
PlacementGroupImpl removedPlacementGroup =
(PlacementGroupImpl) Ray.getPlacementGroup((secondPlacementGroup).getId());
PlacementGroup removedPlacementGroup = Ray.getPlacementGroup((secondPlacementGroup).getId());
Assert.assertEquals(removedPlacementGroup.getState(), PlacementGroupState.REMOVED);
// Wait for placement group after it is removed.