wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-06-28 05:43:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

[tune] Fix trial result fetching (#4219)

Browse Source 
* Fix trial results wait in RayTrialExecutor.get_next_available_trial

* Add comment for the results shuffling

* Remove timeout from the wait

* Change random.sample to random.shuffle
This commit is contained in:
Kristian Hartikainen
2019-03-04 14:26:10 -08:00
committed by Richard Liaw
parent 6e3384a719
commit df9beb7123
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/ray/tune/ray_trial_executor.py
+8 -1
View File
@@ -5,6 +5,7 @@ from __future__ import print_function
import logging
import os
import random
import time
import traceback
@@ -230,7 +231,13 @@ class RayTrialExecutor(TrialExecutor):
return list(self._running.values())
def get_next_available_trial(self):
[result_id], _ = ray.wait(list(self._running))
shuffled_results = list(self._running.keys())
random.shuffle(shuffled_results)
# Note: We shuffle the results because `ray.wait` by default returns
# the first available result, and we want to guarantee that slower
# trials (i.e. trials that run remotely) also get fairly reported.
# See https://github.com/ray-project/ray/issues/4211 for details.
[result_id], _ = ray.wait(shuffled_results)
return self._running[result_id]
def fetch_result(self, trial):