From e434ffe06c021f4e8dc20c26145e09599f8cb4c9 Mon Sep 17 00:00:00 2001 From: Eric Liang Date: Mon, 15 Feb 2021 19:25:14 -0800 Subject: [PATCH] [tune] Avoid crash in client mode when return results creating logdir (#14115) --- python/ray/tune/trial.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/python/ray/tune/trial.py b/python/ray/tune/trial.py index 007017780..7507ab50d 100644 --- a/python/ray/tune/trial.py +++ b/python/ray/tune/trial.py @@ -1,6 +1,7 @@ from typing import Callable, Dict, Sequence, Union import json +import ray import ray.cloudpickle as cloudpickle from collections import deque import copy @@ -640,4 +641,9 @@ class Trial: self.__dict__.update(state) validate_trainable(self.trainable_name) - self.init_logdir() # Create logdir if it does not exist + + # Avoid creating logdir in client mode for returned trial results, + # since the dir might not be creatable locally. TODO(ekl) thsi is kind + # of a hack. + if not ray.util.client.ray.is_connected(): + self.init_logdir() # Create logdir if it does not exist