Expose log files through global state API. (#641)

* added log_table function and a test

* fixed log_files and added task_profiles

* fixed formatting

* fixed linting errors

* fixes

* removed file

* more fixes

* hopefully fixed

* Small changes.

* Fix linting.

* Fix bug in log monitor.

* Small changes.

* Fix bug in travis.

python/ray/experimental/state.py

@@ -304,3 +304,31 @@ class GlobalState(object):
       node_info[node_ip_address].append(client_info_parsed)
 
     return node_info
+
+  def log_files(self):
+    """Fetch and return a dictionary of log file names to outputs.
+
+    Returns:
+      IP address to log file name to log file contents mappings.
+    """
+    relevant_files = self.redis_client.keys("LOGFILE*")
+
+    ip_filename_file = dict()
+
+    for filename in relevant_files:
+      filename = filename.decode("ascii")
+      filename_components = filename.split(":")
+      ip_addr = filename_components[1]
+
+      file = self.redis_client.lrange(filename, 0, -1)
+      file_str = []
+      for x in file:
+        y = x.decode("ascii")
+        file_str.append(y)
+
+      if ip_addr not in ip_filename_file:
+        ip_filename_file[ip_addr] = dict()
+
+      ip_filename_file[ip_addr][filename] = file_str
+
+    return ip_filename_file

python/ray/log_monitor.py

@@ -48,7 +48,16 @@ class LogMonitor(object):
     for log_filename in self.log_files:
       if log_filename in self.log_file_handles:
         # Get any updates to the file.
-        new_lines = self.log_file_handles[log_filename].readlines()
+        new_lines = []
+        while True:
+          current_position = self.log_file_handles[log_filename].tell()
+          next_line = self.log_file_handles[log_filename].readline()
+          if next_line != "":
+            new_lines.append(next_line)
+          else:
+            self.log_file_handles[log_filename].seek(current_position)
+            break
+
         # If there are any new lines, cache them and also push them to Redis.
         if len(new_lines) > 0:
           self.log_files[log_filename] += new_lines
@@ -58,7 +67,7 @@ class LogMonitor(object):
       else:
         try:
           self.log_file_handles[log_filename] = open(log_filename, "r")
-        except FileNotFoundError:
+        except IOError:
           print("Warning: The file {} was not found.".format(log_filename))
 
   def run(self):