From f3ef9060e45362702853c5ddeaca4c082bcab403 Mon Sep 17 00:00:00 2001
From: mehrdadn <mehrdadn@users.noreply.github.com>
Date: Mon, 20 Jul 2020 12:55:07 -0700
Subject: [PATCH] Handle warnings in core (#9575)

---
 .../core_worker/transport/direct_actor_transport.h   | 12 +-----------
 src/ray/rpc/worker/core_worker_client.h              |  3 ++-
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/src/ray/core_worker/transport/direct_actor_transport.h b/src/ray/core_worker/transport/direct_actor_transport.h
index b0571b810..e3d4dae3b 100644
--- a/src/ray/core_worker/transport/direct_actor_transport.h
+++ b/src/ray/core_worker/transport/direct_actor_transport.h
@@ -14,12 +14,6 @@
 
 #pragma once
 
-#ifdef __clang__
-// TODO(mehrdadn): Remove this when the warnings are addressed
-#pragma clang diagnostic push
-#pragma clang diagnostic warning "-Wunused-result"
-#endif
-
 #include <boost/asio/thread_pool.hpp>
 #include <boost/thread.hpp>
 #include <list>
@@ -280,7 +274,7 @@ class DependencyWaiterImpl : public DependencyWaiter {
             std::function<void()> on_dependencies_available) override {
     auto tag = next_request_id_++;
     requests_[tag] = on_dependencies_available;
-    dependency_client_.WaitForDirectActorCallArgs(dependencies, tag);
+    RAY_CHECK_OK(dependency_client_.WaitForDirectActorCallArgs(dependencies, tag));
   }
 
   /// Fulfills the callback stored by Wait().
@@ -531,7 +525,3 @@ class CoreWorkerDirectTaskReceiver {
 };
 
 }  // namespace ray
-
-#ifdef __clang__
-#pragma clang diagnostic pop
-#endif
diff --git a/src/ray/rpc/worker/core_worker_client.h b/src/ray/rpc/worker/core_worker_client.h
index c3dd95658..55e34467b 100644
--- a/src/ray/rpc/worker/core_worker_client.h
+++ b/src/ray/rpc/worker/core_worker_client.h
@@ -312,7 +312,8 @@ class CoreWorkerClient : public std::enable_shared_from_this<CoreWorkerClient>,
         callback(status, reply);
       };
 
-      INVOKE_RPC_CALL(CoreWorkerService, PushTask, *request, rpc_callback, grpc_client_);
+      RAY_UNUSED(INVOKE_RPC_CALL(CoreWorkerService, PushTask, *request, rpc_callback,
+                                 grpc_client_));
     }
 
     if (!send_queue_.empty()) {