From f587b9a50c2172c1300886a5ea6ca99e622f7ceb Mon Sep 17 00:00:00 2001 From: Tao Wang Date: Wed, 13 Jan 2021 09:55:27 +0800 Subject: [PATCH] Remove unimplemented GetAll method in actor info accessor (#13362) --- src/ray/gcs/accessor.h | 6 ------ src/ray/gcs/gcs_client/service_based_accessor.cc | 5 ----- src/ray/gcs/gcs_client/service_based_accessor.h | 2 -- 3 files changed, 13 deletions(-) diff --git a/src/ray/gcs/accessor.h b/src/ray/gcs/accessor.h index eac5ae5e7..19dc7f1de 100644 --- a/src/ray/gcs/accessor.h +++ b/src/ray/gcs/accessor.h @@ -33,12 +33,6 @@ class ActorInfoAccessor { public: virtual ~ActorInfoAccessor() = default; - /// Get all actor specification from GCS synchronously. - /// - /// \param actor_table_data_list The container to hold the actor specification. - /// \return Status - virtual Status GetAll(std::vector *actor_table_data_list) = 0; - /// Get actor specification from GCS asynchronously. /// /// \param actor_id The ID of actor to look up in the GCS. diff --git a/src/ray/gcs/gcs_client/service_based_accessor.cc b/src/ray/gcs/gcs_client/service_based_accessor.cc index 0f30d748d..08c1e3500 100644 --- a/src/ray/gcs/gcs_client/service_based_accessor.cc +++ b/src/ray/gcs/gcs_client/service_based_accessor.cc @@ -131,11 +131,6 @@ ServiceBasedActorInfoAccessor::ServiceBasedActorInfoAccessor( ServiceBasedGcsClient *client_impl) : client_impl_(client_impl) {} -Status ServiceBasedActorInfoAccessor::GetAll( - std::vector *actor_table_data_list) { - return Status::Invalid("Not implemented"); -} - Status ServiceBasedActorInfoAccessor::AsyncGet( const ActorID &actor_id, const OptionalItemCallback &callback) { RAY_LOG(DEBUG) << "Getting actor info, actor id = " << actor_id diff --git a/src/ray/gcs/gcs_client/service_based_accessor.h b/src/ray/gcs/gcs_client/service_based_accessor.h index 5133a9512..9d7c53743 100644 --- a/src/ray/gcs/gcs_client/service_based_accessor.h +++ b/src/ray/gcs/gcs_client/service_based_accessor.h @@ -70,8 +70,6 @@ class ServiceBasedActorInfoAccessor : public ActorInfoAccessor { virtual ~ServiceBasedActorInfoAccessor() = default; - Status GetAll(std::vector *actor_table_data_list) override; - Status AsyncGet(const ActorID &actor_id, const OptionalItemCallback &callback) override;