Commit Graph

1366 Commits

Author SHA1 Message Date
SangBin Cho 826f14c824 [Stats] Fix harvestor threads + Fix flaky stats shutdown. (#9745) 2020-07-29 18:57:59 -05:00
mehrdadn 07022f3f11 Fix src/ray/core_worker/common.h deleted constructor (#9785)
Co-authored-by: Mehrdad <noreply@github.com>
2020-07-29 15:49:02 -07:00
Alex Wu 72297dc46f [Core] Socket creation race condition bug fixes (#9764)
* fix issues

* hot fixes

* test

* test

* Always info log
2020-07-29 13:17:46 -07:00
SangBin Cho d1b37ca7e4 [GCS Actor Management] Fix flaky test_dead_actors. (#9715)
* Fix.

* Add logs.

* Add an unit test.
2020-07-29 10:54:18 -07:00
Tao Wang 2babad9906 [GCS]Use a separate thread in node failure detector to handle heartbeat (#9416)
* use a sole thread to handle heartbeat

* separate signal thread

* use work to avoid exiting when task is underway

* protect shared data structure to avoid deadlock

* add comments

* decrease io service num

* minor changes

* fix test

* per stephanie's comments

* use single io service instead of 1-size io service pool

* typo
2020-07-29 09:58:58 -07:00
Lingxuan Zuo 156067b423 [Stats] enable core worker stats (#9355) 2020-07-29 17:28:33 +08:00
fangfengbin a484947742 Fix leased worker leak bug if lease worker requests that are still waiting to be scheduled when GCS restarts (#9719) 2020-07-29 14:16:03 +08:00
Alex Wu 21af0ceb0c Register function race (#9346) 2020-07-28 13:51:34 -07:00
SangBin Cho 7e3ba289dc [Stats] Basic Metrics Infrastructure (Metrics Agent + Prometheus Exporter) (#9607) 2020-07-28 10:28:01 -07:00
Alex Wu feb3751824 [New scheduler] First unit test for task manager (#9696)
* .

* .

* refactor WorkerInterface

* .

* Basic unit test structure complete?

* .

* bad git >:-(

* small clean up

* CR

* .

* .

* One more fixture

* One more fixture

* .

* .

* bazel-format

* .
2020-07-28 09:44:58 -07:00
fangfengbin bd18e975c0 fix windows compile bug (#9741)
Co-authored-by: 灵洵 <fengbin.ffb@antfin.com>
2020-07-28 21:30:31 +08:00
Lingxuan Zuo 1049c9e53b [Stats] fix stats shutdown crash if opencensus exporter not initialized (#9727) 2020-07-28 11:21:10 +08:00
Alisa 51e12ee97c Python api of placement group (#9243) 2020-07-27 14:57:05 -07:00
Ian Rodney d35605079e [core] Removes Error when Internal Config is not set (#9700) 2020-07-27 11:47:54 -07:00
fangfengbin 2790818c53 [GCS]GCS client support multi-thread subscribe&resubscribe&unsubscribe (#9718) 2020-07-27 13:58:39 +08:00
ZhuSenlin a269ae9bc4 [GCS] Fix actor task hang when its owner exits before local dependencies resolved (#8045) 2020-07-27 10:56:52 +08:00
Tao Wang c6a7b3ac68 [Tests]lock vector to avoid potential flaky test (#9656) 2020-07-26 11:57:28 +08:00
Siyuan (Ryans) Zhuang 54a0d8b69e [Core] Try remove all windows compat shims (#9671)
* try remove compat for arrow

* remove unistd.h

* remove socket compat

* delete arrow windows patch
2020-07-25 12:00:36 -07:00
SangBin Cho d49b19c24c [Stats] Improve Stats::Init & Add it to GCS server (#9563) 2020-07-25 10:42:08 -07:00
fangfengbin 28d5f9696d Add placement group java api (#9611)
* add part code

* add part code

* add part code

* fix code style

* fix review comment

* fix review comment

* add part code

* add part code

* add part code

* add part code

* fix review comment

* fix review comment

* fix code style

* fix review comment

* fix lint error

* fix lint error

Co-authored-by: 灵洵 <fengbin.ffb@antfin.com>
2020-07-25 15:39:05 +08:00
mehrdadn 6beed5a2df Fix ERROR logging not being printed to standard error (#9633)
Co-authored-by: Mehrdad <noreply@github.com>
2020-07-24 11:15:00 -07:00
fangfengbin d4324a4a8f fix java coreworker crash (#9674) 2020-07-24 15:36:49 +08:00
Stephanie Wang f2705e2c73 [core] Enable object reconstruction for retryable actor tasks (#9557)
* Test actor plasma reconstruction

* Allow resubmission of actor tasks

* doc

* Test for actor constructor

* Kill PID before removing node

* Kill pid before node
2020-07-23 21:15:12 -07:00
Alex Wu 239196fffc [Core] WorkerInterface refactor (#9655)
* .

* .

* refactor WorkerInterface

* .

* Basic unit test structure complete?

* .

* .

* .

* .

* Fixed tests

* Fixed tests

* .
2020-07-23 21:13:29 -07:00
Siyuan (Ryans) Zhuang e4beffa49d Remove unused windows shims (#9583) 2020-07-23 17:18:39 -07:00
Siyuan (Ryans) Zhuang 4594f7db2e [Core] Remove unnecessary windows syscall in plasma store (#9602) 2020-07-23 17:14:25 -07:00
fangfengbin 5ab17e0dd8 Fix TestObjectTableResubscribe testcase bug (#9650) 2020-07-23 20:28:31 +08:00
Lingxuan Zuo 64b0f173c8 fix window jni unhappy compiler (#9635) 2020-07-23 19:43:53 +08:00
Siyuan (Ryans) Zhuang 993ff5fd81 [Core] Fix concurrency issues in plasma store runner (#9642) 2020-07-23 00:12:10 -07:00
SangBin Cho ca391ed052 [Core] GCS Actor management on by default. (#8845)
* GCS Actor management on by default.

* Fix travis config.

* Change condition.

* Remove unnecessary CI.
2020-07-22 14:31:41 -07:00
Kai Yang bfa0605282 [Java] Avoid data copy from C++ to Java for ByteBuffer type (#9033) 2020-07-22 16:25:32 +08:00
mehrdadn b14728d999 Shellcheck quoting (#9596)
* Fix SC2006: Use $(...) notation instead of legacy backticked `...`.

* Fix SC2016: Expressions don't expand in single quotes, use double quotes for that.

* Fix SC2046: Quote this to prevent word splitting.

* Fix SC2053: Quote the right-hand side of == in [[ ]] to prevent glob matching.

* Fix SC2068: Double quote array expansions to avoid re-splitting elements.

* Fix SC2086: Double quote to prevent globbing and word splitting.

* Fix SC2102: Ranges can only match single chars (mentioned due to duplicates).

* Fix SC2140: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"?

* Fix SC2145: Argument mixes string and array. Use * or separate argument.

* Fix SC2209: warning: Use var=$(command) to assign output (or quote to assign string).

Co-authored-by: Mehrdad <noreply@github.com>
2020-07-21 21:56:41 -05:00
ZhuSenlin 382b314241 [GCS] fix the fault tolerance about gcs node manager (#9380) 2020-07-22 10:55:51 +08:00
Lingxuan Zuo cd42450fc1 [Metrics] Java metric API (#9377) 2020-07-22 10:35:08 +08:00
kisuke95 4e2e3bd348 [New scheduler] Fix new scheduler bug (#9467)
* fix new scheduler bug

* add testcase for soft resource allocation

* modify RemoveNode
2020-07-20 13:09:53 -07:00
mehrdadn f3ef9060e4 Handle warnings in core (#9575) 2020-07-20 12:55:07 -07:00
mehrdadn dcec26ac7b Fix log losses (#9559)
* Close log on shutdown

* Disable log buffering

Co-authored-by: Mehrdad <noreply@github.com>
2020-07-20 11:03:58 -07:00
fangfengbin 8605b594f1 Fix Java named actor bug (#9580) 2020-07-20 19:51:00 +08:00
Siyuan (Ryans) Zhuang 4accc16995 [Core] Replace the Plasma eventloop with boost::asio (#9431) 2020-07-20 02:52:51 -07:00
fangfengbin 0cee75c86a GCS client add fetch operation before subscribe (#9564) 2020-07-20 10:16:42 +08:00
mehrdadn 2554a1a997 Bazel fixes (#9519) 2020-07-19 12:53:08 -07:00
Lingxuan Zuo ce3f542739 [Metric] new cython interface for python worker metric (#9469) 2020-07-19 10:43:21 +08:00
Siyuan (Ryans) Zhuang 7edd1e6694 [Core] Remove socket pair exchange in Plasma Store (#9565)
* try use boost::asio for notification processing
2020-07-18 15:47:52 -07:00
fangfengbin b12b8e1324 [GCS]Fix lease worker leak bug when gcs server restarts (#9315)
* add part code

* fix compile bug

* fix review comments

* fix review comments

* fix review comments

* fix review comments

* fix review comment

* fix ut bug

* fix lint error

* fix review comment

* fix review comments

* add testcase

* add testcase

* fix bug

* fix review comments

* fix review comment

* fix review comment

* refine comments

Co-authored-by: 灵洵 <fengbin.ffb@antfin.com>
Co-authored-by: Hao Chen <chenh1024@gmail.com>
2020-07-18 15:49:41 +08:00
Alex Wu a78c5d5ef2 [New scheduler] Queueing refactor (#9491)
* .

* test_args passes

* .

* test_basic.py::test_many_fractional_resources causes ray to hang

* test_basic.py::test_many_fractional_resources causes ray to hang

* .

* .

* useful

* test_many_fractional_resources fails instead of hanging now :)

* Passes test_fractional_resources

* .

* .

* Some cleanup

* git is hard

* cleanup

* .

* .

* .

* .

* .

* .

* .

* cleanup

* address reviews

* address reviews

* more refactor

* :)

* travis pls

* .

* travis pls

* .
2020-07-17 11:08:03 -07:00
Gabriele Oliaro 026c009086 Pipelining task submission to workers (#9363)
* first step of pipelining

* pipelining tests & default configs
- added pipelining unit tests in direct_task_transport_test.cc
- added an entry in ray_config_def.h, ray_config.pxi, and ray_config.pxd to configure the parameter controlling the maximum number of tasks that can be in fligh to each worker
- consolidated worker_to_lease_client_ and worker_to_lease_client_ hash maps in direct_task_transport.h into a single one called worker_to_lease_entry_

* post-review revisions

* linting, following naming/style convention

* linting
2020-07-17 10:45:13 -07:00
Stephanie Wang b351d13940 [core] Add flag to enable object reconstruction during ray start (#9488)
* Add flag

* doc

* Fix tests
2020-07-17 10:13:14 -07:00
Alisa f080aa6ce3 Add placement group manager and some code in core_worker (#9120)
Co-authored-by: Lingxuan Zuo <skyzlxuan@gmail.com>
2020-07-17 20:49:51 +08:00
mehrdadn 37942ea1e7 Windows cleanup (#9508)
* Remove unneeded code for Windows

* Get rid of usleep()

* Make platform_shims includes non-transitive

Co-authored-by: Mehrdad <noreply@github.com>
2020-07-17 02:08:15 -07:00
Lingxuan Zuo 3a74164289 [Stats] Fix metric exporter test (#9376) 2020-07-17 14:38:24 +08:00