Files
ray/python/ray/serve/long_poll.py
T
2020-12-01 13:07:43 -08:00

167 lines
6.5 KiB
Python

import asyncio
import random
from collections import defaultdict
from dataclasses import dataclass
from typing import Any, Awaitable, Callable, DefaultDict, Dict, Set
import ray
from ray.serve.utils import logger
@dataclass
class UpdatedObject:
object_snapshot: Any
# The identifier for the object's version. There is not sequential relation
# among different object's snapshot_ids.
snapshot_id: int
# Type signature for the update state callbacks. E.g.
# async def update_state(updated_object: Any):
# do_something(updated_object)
UpdateStateAsyncCallable = Callable[[Any], Awaitable[None]]
class LongPollerAsyncClient:
"""The asynchronous long polling client.
Internally, it runs `await object_ref` in a `while True` loop. When a
object notification arrived, the client will invoke callback if supplied.
Note that this client will wait the callback to be completed before issuing
the next poll.
Args:
host_actor(ray.ActorHandle): handle to actor embedding LongPollerHost.
key_listeners(Dict[str, AsyncCallable]): a dictionary mapping keys to
callbacks to be called on state update for the corresponding keys.
"""
def __init__(self, host_actor,
key_listeners: Dict[str, UpdateStateAsyncCallable]) -> None:
self.host_actor = host_actor
self.key_listeners = key_listeners
self.snapshot_ids: Dict[str, int] = {
key: -1
for key in key_listeners.keys()
}
self.object_snapshots: Dict[str, Any] = dict()
in_async_loop = asyncio.get_event_loop().is_running
assert in_async_loop, "The client is only available in async context."
asyncio.get_event_loop().create_task(self._do_long_poll())
def _poll_once(self) -> ray.ObjectRef:
object_ref = self.host_actor.listen_for_change.remote(
self.snapshot_ids)
return object_ref
def _update(self, updates: Dict[str, UpdatedObject]):
for key, update in updates.items():
self.object_snapshots[key] = update.object_snapshot
self.snapshot_ids[key] = update.snapshot_id
async def _do_long_poll(self):
while True:
try:
updates: Dict[str, UpdatedObject] = await self._poll_once()
self._update(updates)
logger.debug(f"LongPollerClient received udpates: {updates}")
for key, updated_object in updates.items():
# NOTE(simon):
# This blocks the loop from doing another poll. Consider
# use loop.create_task here or poll first then call the
# callbacks.
callback = self.key_listeners[key]
await callback(updated_object.object_snapshot)
except ray.exceptions.RayActorError:
# This can happen during shutdown where the controller is
# intentionally killed, the client should just gracefully
# exit.
logger.debug("LongPollerClient failed to connect to host. "
"Shutting down.")
break
class LongPollerHost:
"""The server side object that manages long pulling requests.
The desired use case is to embed this in an Ray actor. Client will be
expected to call actor.listen_for_change.remote(...). On the host side,
you can call host.notify_changed(key, object) to update the state and
potentially notify whoever is polling for these values.
Internally, we use snapshot_ids for each object to identify client with
outdated object and immediately return the result. If the client has the
up-to-date verison, then the listen_for_change call will only return when
the object is updated.
"""
def __init__(self):
# Map object_key -> int
self.snapshot_ids: DefaultDict[str, int] = defaultdict(
lambda: random.randint(0, 1_000_000))
# Map object_key -> object
self.object_snapshots: Dict[str, Any] = dict()
# Map object_key -> set(asyncio.Event waiting for updates)
self.notifier_events: DefaultDict[str, Set[
asyncio.Event]] = defaultdict(set)
async def listen_for_change(self, keys_to_snapshot_ids: Dict[str, int]
) -> Dict[str, UpdatedObject]:
"""Listen for changed objects.
This method will returns a dictionary of updated objects. It returns
immediately if the snapshot_ids are outdated, otherwise it will block
until there's one updates.
"""
# 1. Figure out which keys do we care about
watched_keys = set(self.snapshot_ids.keys()).intersection(
keys_to_snapshot_ids.keys())
if len(watched_keys) == 0:
raise ValueError("Keys not found.")
# 2. If there are any outdated keys (by comparing snapshot ids)
# return immediately.
client_outdated_keys = {
key: UpdatedObject(self.object_snapshots[key],
self.snapshot_ids[key])
for key in watched_keys
if self.snapshot_ids[key] != keys_to_snapshot_ids[key]
}
if len(client_outdated_keys) > 0:
return client_outdated_keys
# 3. Otherwise, register asyncio events to be waited.
async_task_to_watched_keys = {}
for key in watched_keys:
# Create a new asyncio event for this key
event = asyncio.Event()
task = asyncio.get_event_loop().create_task(event.wait())
async_task_to_watched_keys[task] = key
# Make sure future caller of notify_changed will unblock this
# asyncio Event.
self.notifier_events[key].add(event)
done, not_done = await asyncio.wait(
async_task_to_watched_keys.keys(),
return_when=asyncio.FIRST_COMPLETED)
[task.cancel() for task in not_done]
updated_object_key: str = async_task_to_watched_keys[done.pop()]
return {
updated_object_key: UpdatedObject(
self.object_snapshots[updated_object_key],
self.snapshot_ids[updated_object_key])
}
def notify_changed(self, object_key: str, updated_object: Any):
self.snapshot_ids[object_key] += 1
self.object_snapshots[object_key] = updated_object
logger.debug(f"LongPollerHost: {object_key} = {updated_object}")
if object_key in self.notifier_events:
for event in self.notifier_events.pop(object_key):
event.set()