mirror of
https://github.com/wassname/ray.git
synced 2026-06-28 11:53:32 +08:00
dHannasch
d35de2272d
* redis.ResponseError * there really is no way to make this look good, is there
82 lines
2.8 KiB
Python
82 lines
2.8 KiB
Python
import os
|
|
import pytest
|
|
import redis
|
|
|
|
import ray
|
|
import ray._private.services
|
|
from ray.cluster_utils import Cluster
|
|
|
|
|
|
@pytest.fixture
|
|
def password():
|
|
random_bytes = os.urandom(128)
|
|
if hasattr(random_bytes, "hex"):
|
|
return random_bytes.hex() # Python 3
|
|
return random_bytes.encode("hex") # Python 2
|
|
|
|
|
|
class TestRedisPassword:
|
|
def test_redis_password(self, password, shutdown_only):
|
|
@ray.remote
|
|
def f():
|
|
return 1
|
|
|
|
info = ray.init(_redis_password=password)
|
|
address = info["redis_address"]
|
|
redis_ip, redis_port = address.split(":")
|
|
|
|
# Check that we can run a task
|
|
object_ref = f.remote()
|
|
ray.get(object_ref)
|
|
|
|
# Check that Redis connections require a password
|
|
redis_client = redis.StrictRedis(
|
|
host=redis_ip, port=redis_port, password=None)
|
|
with pytest.raises(redis.exceptions.AuthenticationError):
|
|
redis_client.ping()
|
|
# We want to simulate how this is called by ray.scripts.start().
|
|
try:
|
|
ray._private.services.wait_for_redis_to_start(
|
|
redis_ip, redis_port, password="wrong password")
|
|
# We catch a generic Exception here in case someone later changes the
|
|
# type of the exception.
|
|
except Exception as ex:
|
|
if not (isinstance(ex.__cause__, redis.AuthenticationError)
|
|
and "invalid password" in str(ex.__cause__)) and not (
|
|
isinstance(ex, redis.ResponseError) and
|
|
"WRONGPASS invalid username-password pair" in str(ex)):
|
|
raise
|
|
# By contrast, we may be fairly confident the exact string
|
|
# 'invalid password' won't go away, because redis-py simply wraps
|
|
# the exact error from the Redis library.
|
|
# https://github.com/andymccurdy/redis-py/blob/master/
|
|
# redis/connection.py#L132
|
|
# Except, apparently sometimes redis-py raises a completely
|
|
# different *type* of error for a bad password,
|
|
# redis.ResponseError, which is not even derived from
|
|
# redis.ConnectionError as redis.AuthenticationError is.
|
|
|
|
# Check that we can connect to Redis using the provided password
|
|
redis_client = redis.StrictRedis(
|
|
host=redis_ip, port=redis_port, password=password)
|
|
assert redis_client.ping()
|
|
|
|
def test_redis_password_cluster(self, password, shutdown_only):
|
|
@ray.remote
|
|
def f():
|
|
return 1
|
|
|
|
node_args = {"redis_password": password}
|
|
cluster = Cluster(
|
|
initialize_head=True, connect=True, head_node_args=node_args)
|
|
cluster.add_node(**node_args)
|
|
|
|
object_ref = f.remote()
|
|
ray.get(object_ref)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
import pytest
|
|
import sys
|
|
sys.exit(pytest.main(["-v", __file__]))
|