From 9a522c8b44daf015fa250e46b2b4cd9b96ff869c Mon Sep 17 00:00:00 2001 From: Stefan van der Walt Date: Thu, 28 Jan 2016 18:56:57 -0800 Subject: [PATCH] Update contributor's guide: all PRs must get two +1's by core team before merge --- CONTRIBUTING.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.txt b/CONTRIBUTING.txt index 29dba55d..38bb784d 100644 --- a/CONTRIBUTING.txt +++ b/CONTRIBUTING.txt @@ -77,6 +77,8 @@ For a more detailed discussion, read these :doc:`detailed documents Travis fails, you can find out why by clicking on the "failed" icon (red cross) and inspecting the build and test log. + * A pull request must be approved by two core team members before merging. + 5. Document changes If your change introduces any API modifications, please update @@ -127,7 +129,8 @@ Guidelines * All code should be documented, to the same `standard `_ as NumPy and SciPy. * For new functionality, always add an example to the gallery. -* No changes are ever committed without review. Ask on the +* No changes are ever committed without review and approval by two core + team members. Ask on the `mailing list `_ if you get no response to your pull request. **Never merge your own pull request.**