From ed734ebb08745821f0ba7c0da20cc60b097cbe51 Mon Sep 17 00:00:00 2001 From: Jessie Rushing Date: Wed, 8 May 2019 15:42:06 -0700 Subject: [PATCH 1/4] update fb app creation steps --- plugins/talk-plugin-facebook-auth/README.md | 42 +++++++++++++++------ 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/plugins/talk-plugin-facebook-auth/README.md b/plugins/talk-plugin-facebook-auth/README.md index 91a60be65..f9101dfc8 100644 --- a/plugins/talk-plugin-facebook-auth/README.md +++ b/plugins/talk-plugin-facebook-auth/README.md @@ -11,23 +11,43 @@ plugin: - Client --- -Enables sign-in via Facebook via the server side passport middleware. +Enables sign-in via Facebook via the server side passport middleware. Requires creating and registering a login app with FaceBook. -Configuration: +**Configuration:** - `TALK_FACEBOOK_APP_ID` (**required**) - The Facebook App ID for your Facebook - Login enabled app. You can learn more about getting a Facebook App ID at the - [Facebook Developers Portal](https://developers.facebook.com) or by visiting - the [Creating an App ID](https://developers.facebook.com/docs/apps/register) - guide. This is only required while the `talk-plugin-facebook-auth` plugin is + Login enabled app. This is only required while the `talk-plugin-facebook-auth` plugin is enabled. - `TALK_FACEBOOK_APP_SECRET` (**required**) - The Facebook App Secret for your - Facebook Login enabled app. You can learn more about getting a Facebook App - Secret at the [Facebook Developers Portal](https://developers.facebook.com) - or by visiting the - [Creating an App ID](https://developers.facebook.com/docs/apps/register) - guide. This is only required while the `talk-plugin-facebook-auth` plugin is + Facebook Login enabled app. This is only required while the `talk-plugin-facebook-auth` plugin is enabled. + +You can learn more about getting a Facebook App ID at the + [Facebook Developers Portal](https://developers.facebook.com) or by visiting + their [Creating an App ID](https://developers.facebook.com/docs/apps/register) + guide. + +**Setting up your FaceBook app:** +* Go to My Apps > Create A New App +* Add an App Name and Email to create an app id +* Confirm that you are not a robot +* Go to Settings > Basic: + * add app domains (your Talk domain) + * add a link to your privacy policy + * add a link to your terms of service + * save changes +* Go to Settings > Advanced: + * turn on "Require App Secret" +* Under "Products" click + to add a Product: + * Select "Let people log in with FaceBook" + * choose `www` + * enter your Talk domain url + * click _Next_ several times to get through the add code steps (You do not need to modify any code, the plugin takes care of this part for you.) +* Go back to Settings > Basic: + * enter the callback url + * Locate your App Id and App Secret, set these as config vars on your instance of Talk +* Toggle the "Live" button to make app live + _NOTE: Facebook auth requires your site to use `https` (SSL) not `http`. If your site is not `https` you can not use this plugin!_ From 39e45c30bafa5c8c0f4264e29290afbc62e38a93 Mon Sep 17 00:00:00 2001 From: Jessie Rushing Date: Wed, 8 May 2019 16:05:13 -0700 Subject: [PATCH 2/4] added callback url --- plugins/talk-plugin-facebook-auth/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/talk-plugin-facebook-auth/README.md b/plugins/talk-plugin-facebook-auth/README.md index f9101dfc8..08247e3f2 100644 --- a/plugins/talk-plugin-facebook-auth/README.md +++ b/plugins/talk-plugin-facebook-auth/README.md @@ -44,7 +44,7 @@ You can learn more about getting a Facebook App ID at the * enter your Talk domain url * click _Next_ several times to get through the add code steps (You do not need to modify any code, the plugin takes care of this part for you.) * Go back to Settings > Basic: - * enter the callback url + * enter the callback url (Use your Talk domain with this endpoint: `/api/v1/auth/facebook/callback`) * Locate your App Id and App Secret, set these as config vars on your instance of Talk * Toggle the "Live" button to make app live From b6ed5b792bf5a65ad5205a2b3d89bbc5cd2a534d Mon Sep 17 00:00:00 2001 From: Jessie Rushing Date: Thu, 9 May 2019 15:07:40 -0700 Subject: [PATCH 3/4] updated Fb dev steps --- plugins/talk-plugin-facebook-auth/README.md | 23 ++++++++++----------- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/plugins/talk-plugin-facebook-auth/README.md b/plugins/talk-plugin-facebook-auth/README.md index 08247e3f2..4dd1d348b 100644 --- a/plugins/talk-plugin-facebook-auth/README.md +++ b/plugins/talk-plugin-facebook-auth/README.md @@ -11,7 +11,7 @@ plugin: - Client --- -Enables sign-in via Facebook via the server side passport middleware. Requires creating and registering a login app with FaceBook. +Enables sign-in via Facebook via the server side passport middleware. Requires creating and registering a login app with Facebook. **Configuration:** @@ -27,24 +27,23 @@ You can learn more about getting a Facebook App ID at the their [Creating an App ID](https://developers.facebook.com/docs/apps/register) guide. -**Setting up your FaceBook app:** -* Go to My Apps > Create A New App -* Add an App Name and Email to create an app id -* Confirm that you are not a robot -* Go to Settings > Basic: +**Setting up your Facebook app:** +* Go to [Facebook Developers Portal](https://developers.facebook.com) and click on Getting Started or My Apps +* Create a new app > set the App Name and Email to create an app id +* Confirm that you are not a robot, then configure the app as follows: +* In Settings > Basic: * add app domains (your Talk domain) * add a link to your privacy policy * add a link to your terms of service - * save changes -* Go to Settings > Advanced: +* In Settings > Advanced: * turn on "Require App Secret" -* Under "Products" click + to add a Product: - * Select "Let people log in with FaceBook" +* Add a "Product" (Under "Products" click + to add a Product): + * Setup "Facebook Login" * choose `www` * enter your Talk domain url * click _Next_ several times to get through the add code steps (You do not need to modify any code, the plugin takes care of this part for you.) -* Go back to Settings > Basic: - * enter the callback url (Use your Talk domain with this endpoint: `/api/v1/auth/facebook/callback`) +* Under Product Settings: + * set Valid OAuth Redirect URIs to your callback url (Use your Talk domain with this endpoint: `/api/v1/auth/facebook/callback`) * Locate your App Id and App Secret, set these as config vars on your instance of Talk * Toggle the "Live" button to make app live From f2129082a9004b96f288e4e147e59ef6cd3bb324 Mon Sep 17 00:00:00 2001 From: Jessie Rushing Date: Thu, 9 May 2019 15:35:41 -0700 Subject: [PATCH 4/4] added note about location of live button --- plugins/talk-plugin-facebook-auth/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/talk-plugin-facebook-auth/README.md b/plugins/talk-plugin-facebook-auth/README.md index 4dd1d348b..4a3dbe44f 100644 --- a/plugins/talk-plugin-facebook-auth/README.md +++ b/plugins/talk-plugin-facebook-auth/README.md @@ -45,7 +45,7 @@ You can learn more about getting a Facebook App ID at the * Under Product Settings: * set Valid OAuth Redirect URIs to your callback url (Use your Talk domain with this endpoint: `/api/v1/auth/facebook/callback`) * Locate your App Id and App Secret, set these as config vars on your instance of Talk -* Toggle the "Live" button to make app live +* Toggle the "Live" button on the top bar to make app live _NOTE: Facebook auth requires your site to use `https` (SSL) not `http`. If your site is not `https` you can not use this plugin!_