From 044cbd39f1b7e50636a20610f6e95eecb75eaa6f Mon Sep 17 00:00:00 2001 From: Tessa Thornton Date: Fri, 18 Oct 2019 16:58:14 -0400 Subject: [PATCH] Revert "ensure tab text doesn't get cut off if tab titles are long (#2619)" (#2654) This reverts commit 8409dbb4ea93186aa19399e1d3f6351989a846ae. --- .../tabs/Comments/Stream/StreamContainer.css | 37 +- .../tabs/Comments/Stream/StreamContainer.tsx | 97 ++- .../renderFeaturedStream.spec.tsx.snap | 178 +++-- .../renderCommunityGuidelines.spec.tsx.snap | 176 +++-- .../renderMessageBox.spec.tsx.snap | 704 +++++++++--------- .../__snapshots__/renderStream.spec.tsx.snap | 178 +++-- .../__snapshots__/account.spec.tsx.snap | 10 +- src/core/client/ui/components/Tabs/Tab.tsx | 2 +- .../Tabs/__snapshots__/Tab.spec.tsx.snap | 2 +- .../Tabs/__snapshots__/TabBar.spec.tsx.snap | 6 +- 10 files changed, 653 insertions(+), 737 deletions(-) diff --git a/src/core/client/stream/tabs/Comments/Stream/StreamContainer.css b/src/core/client/stream/tabs/Comments/Stream/StreamContainer.css index 6dbe4f92f..bdd25d92f 100644 --- a/src/core/client/stream/tabs/Comments/Stream/StreamContainer.css +++ b/src/core/client/stream/tabs/Comments/Stream/StreamContainer.css @@ -8,6 +8,9 @@ } .sortMenu { + position: absolute; + right: 0; + top: 0; } .featuredCommentsInfo { @@ -19,41 +22,7 @@ .featuredCommentsTabContainer { position: relative; - overflow: hidden; } - -.featuredCommentsTabContainer > li { - display: block; -} - .featuredCommentsTab { padding-right: 30px !important; - width: 100%; -} - -.tabBar { - flex: 2; - overflow: hidden; -} - -.featuredTabText { - overflow: hidden; - text-overflow: ellipsis; -} - -.tabListItem { - display: block; -} - -.allCommentsTabContainer { - overflow: hidden; -} - -.allCommentsTab { - width: 100%; -} - -.allCommentsTabText { - overflow: hidden; - text-overflow: ellipsis; } diff --git a/src/core/client/stream/tabs/Comments/Stream/StreamContainer.tsx b/src/core/client/stream/tabs/Comments/Stream/StreamContainer.tsx index fa1005152..1474ecc41 100644 --- a/src/core/client/stream/tabs/Comments/Stream/StreamContainer.tsx +++ b/src/core/client/stream/tabs/Comments/Stream/StreamContainer.tsx @@ -149,68 +149,57 @@ export const StreamContainer: FunctionComponent = props => { /> )} - - - {featuredCommentsCount > 0 && ( - - - - Featured - - - {featuredCommentsCount} - - - - )} - - - - - All Comments - + + + {featuredCommentsCount > 0 && ( + + + + Featured - {allCommentsCount} + {featuredCommentsCount} - - - - - + + )} + + + + All Comments + + + {allCommentsCount} + + + +