Center sign in popovers over the browser window so they are easily visible (#2457)

* Center sign in popovers in the browser window so they are always visible

* Set popover window feature by default using interfaced parameters

* Update snapshots to account for feature parameters on popup windows

* Lowercase the bar in menubar for Popup so it matches window api

* fix: externalized feature reconciliation
This commit is contained in:
Nick Funk
2019-08-12 17:03:09 -04:00
committed by Kim Gardner
parent fda9f40616
commit 0eddf9619f
4 changed files with 49 additions and 8 deletions
@@ -127,7 +127,6 @@ export class UserBoxContainer extends Component<Props> {
<Popup
href={this.authUrl}
title="Coral Auth"
features="menubar=0,resizable=0,width=350,height=450,top=100,left=500"
open={open}
focus={focus}
onFocus={this.handleFocus}
@@ -3,7 +3,6 @@
exports[`renders fully 1`] = `
<React.Fragment>
<Popup
features="menubar=0,resizable=0,width=350,height=450,top=100,left=500"
focus={false}
href="/embed/auth?view=SIGN_IN"
onBlur={[Function]}
@@ -27,7 +26,6 @@ exports[`renders sso only without logout button 1`] = `null`;
exports[`renders without logout button 1`] = `
<React.Fragment>
<Popup
features="menubar=0,resizable=0,width=350,height=450,top=100,left=500"
focus={false}
href="/embed/auth?view=SIGN_IN"
onBlur={[Function]}
@@ -47,7 +45,6 @@ exports[`renders without logout button 1`] = `
exports[`renders without register button 1`] = `
<React.Fragment>
<Popup
features="menubar=0,resizable=0,width=350,height=450,top=100,left=500"
focus={false}
href="/embed/auth?view=SIGN_IN"
onBlur={[Function]}
@@ -53,7 +53,6 @@ const ChangePasswordContainer: FunctionComponent<Props> = ({
<Popup
href={`${urls.embed.auth}?view=${view}`}
title="Coral Auth"
features="menubar=0,resizable=0,width=350,height=450,top=100,left=500"
open={open}
focus={focus}
onFocus={onFocus}