From 1239141eb967bc4b565a8afe0abbdd8682772ece Mon Sep 17 00:00:00 2001 From: Riley Davis Date: Thu, 22 Dec 2016 14:11:04 -0700 Subject: [PATCH] use setIn to simplify --- client/coral-admin/src/reducers/settings.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/client/coral-admin/src/reducers/settings.js b/client/coral-admin/src/reducers/settings.js index 87bfa6f07..b05418715 100644 --- a/client/coral-admin/src/reducers/settings.js +++ b/client/coral-admin/src/reducers/settings.js @@ -28,19 +28,16 @@ export default (state = initialState, action) => { } }; +// only for updating top-level settings const updateSettings = (state, action) => { const s = state.set('fetchingSettings', false).set('fetchSettingsError', null); const settings = s.get('settings').merge(action.settings); return s.set('settings', settings); }; +// any nested settings must have a specialized setter const updateWordlist = (state, action) => { - const wordlist = state - .get('settings') - .get('wordlist') - .merge({[action.listName]: action.list}); - const settings = state.get('settings').merge({wordlist}); - return state.set('settings', settings); + return state.setIn(['settings', 'wordlist', action.listName], action.wordlist); }; const saveComplete = (state, action) => {