From 1ec1572efbb2e6b0df397a1f92d332ff0318e8af Mon Sep 17 00:00:00 2001 From: Wyatt Johnson Date: Mon, 23 Jul 2018 13:33:44 -0600 Subject: [PATCH] fix: updated client code to respect missing usernames --- .../client/stream/components/Comment/Comment.tsx | 5 +++-- .../stream/containers/CommentContainer.spec.tsx | 15 +++++++++++++++ .../__snapshots__/CommentContainer.spec.tsx.snap | 12 ++++++++++++ 3 files changed, 30 insertions(+), 2 deletions(-) diff --git a/src/core/client/stream/components/Comment/Comment.tsx b/src/core/client/stream/components/Comment/Comment.tsx index f923e4149..03a947a5a 100644 --- a/src/core/client/stream/components/Comment/Comment.tsx +++ b/src/core/client/stream/components/Comment/Comment.tsx @@ -9,7 +9,7 @@ import Username from "./Username"; export interface CommentProps { author: { - username: string; + username: string | null; } | null; body: string | null; createdAt: string; @@ -19,7 +19,8 @@ const Comment: StatelessComponent = props => { return (
- {props.author && {props.author.username}} + {props.author && + props.author.username && {props.author.username}} {props.createdAt} {props.body} diff --git a/src/core/client/stream/containers/CommentContainer.spec.tsx b/src/core/client/stream/containers/CommentContainer.spec.tsx index 98612be38..4836991b8 100644 --- a/src/core/client/stream/containers/CommentContainer.spec.tsx +++ b/src/core/client/stream/containers/CommentContainer.spec.tsx @@ -19,3 +19,18 @@ it("renders username and body", () => { const wrapper = shallow(); expect(wrapper).toMatchSnapshot(); }); + +it("renders body only", () => { + const props: PropTypesOf = { + data: { + author: { + username: null, + }, + body: "Woof", + createdAt: "1995-12-17T03:24:00.000Z", + }, + }; + + const wrapper = shallow(); + expect(wrapper).toMatchSnapshot(); +}); diff --git a/src/core/client/stream/containers/__snapshots__/CommentContainer.spec.tsx.snap b/src/core/client/stream/containers/__snapshots__/CommentContainer.spec.tsx.snap index 9e2476f37..f6ec9754b 100644 --- a/src/core/client/stream/containers/__snapshots__/CommentContainer.spec.tsx.snap +++ b/src/core/client/stream/containers/__snapshots__/CommentContainer.spec.tsx.snap @@ -1,5 +1,17 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP +exports[`renders body only 1`] = ` + +`; + exports[`renders username and body 1`] = `