From 2028e56f48c1d7cc7e5471e047dcd7c495f020ad Mon Sep 17 00:00:00 2001 From: Belen Curcio Date: Tue, 10 Oct 2017 12:40:09 -0300 Subject: [PATCH] using props, not state for selected --- client/coral-ui/components/Dropdown.js | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/client/coral-ui/components/Dropdown.js b/client/coral-ui/components/Dropdown.js index 8b30f6fbe..820f33346 100644 --- a/client/coral-ui/components/Dropdown.js +++ b/client/coral-ui/components/Dropdown.js @@ -10,27 +10,12 @@ class Dropdown extends React.Component { constructor(props) { super(props); this.state = { - selected: { - label: props.label || '', - value: props.value || '' - }, isOpen: false }; } - - componentWillReceiveProps(newProps) { - if (newProps.value && newProps.value !== this.state.selected.value) { - this.setState({ - selected: { - label: newProps.label, - value: newProps.value - } - }); - } - } fireChange = (newState) => { - if (newState.selected !== this.state.selected && this.props.onChange) { + if (this.props.onChange) { this.props.onChange(newState.selected.value); } }