From 25cc1ecb20992a4c31fc3c99cb81e7eaa69ff40f Mon Sep 17 00:00:00 2001 From: Riley Davis Date: Wed, 7 Dec 2016 11:23:59 -1000 Subject: [PATCH] remove debug statements --- models/user.js | 13 ------------- routes/api/user/index.js | 12 ------------ 2 files changed, 25 deletions(-) diff --git a/models/user.js b/models/user.js index cabab8b64..336486a54 100644 --- a/models/user.js +++ b/models/user.js @@ -2,7 +2,6 @@ const mongoose = require('../mongoose'); const uuid = require('uuid'); const bcrypt = require('bcrypt'); const jwt = require('jsonwebtoken'); -const debug = require('debug')('talk:users'); // SALT_ROUNDS is the number of rounds that the bcrypt algorithm will run // through during the salting process. @@ -436,35 +435,23 @@ UserService.findPublicByIdArray = (ids) => { */ UserService.createPasswordResetToken = function (email) { if (!email || typeof email !== 'string') { - debug('the email was missing to createPasswordResetToken. you sent %s', email); return Promise.reject('email is required when creating a JWT for resetting passord'); } - email = email.toLowerCase(); - debug('about to look up user by email %s', email); - return UserModel.findOne({profiles: {$elemMatch: {id: email}}}) .then(user => { if (user === null) { - debug('user was null on createPasswordResetToken lookup'); // since we don't want to reveal that the email does/doesn't exist // just go ahead and resolve the Promise with null and check in the endpoint return Promise.resolve(null); } - debug('found the user! %s going to create the token', JSON.stringify(user, null, 2)); - const payload = {email, jti: uuid.v4(), userId: user.id, version: user.__v}; - - debug('created payload %s', JSON.stringify(payload)); - const token = jwt.sign(payload, process.env.TALK_SESSION_SECRET, {expiresIn: '1d'}); - debug('successfully created the token %s', token); - return token; }); }; diff --git a/routes/api/user/index.js b/routes/api/user/index.js index 05ebf7b61..fa78b7dfe 100644 --- a/routes/api/user/index.js +++ b/routes/api/user/index.js @@ -8,7 +8,6 @@ const path = require('path'); const resetEmailFile = fs.readFileSync(path.resolve(__dirname, '../../../views/password-reset-email.ejs')); const resetEmailTemplate = ejs.compile(resetEmailFile.toString()); const authorization = require('../../../middleware/authorization'); -const debug = require('debug')('talk:users'); router.get('/', authorization.needed('admin'), (req, res, next) => { const { @@ -105,8 +104,6 @@ router.post('/update-password', (req, res, next) => { router.post('/request-password-reset', (req, res, next) => { const {email} = req.body; - debug('/request-password-reset body %s', JSON.stringify(req.body, null, 2)); - if (!email) { return next('you must submit an email when requesting a password.'); } @@ -115,7 +112,6 @@ router.post('/request-password-reset', (req, res, next) => { .createPasswordResetToken(email) .then(token => { if (token === null) { - debug('back in the route. the token was null for some reason %s', token); return Promise.resolve('the email was not found in the db.'); } @@ -130,23 +126,15 @@ router.post('/request-password-reset', (req, res, next) => { }) }; - debug('about to send a simple email with the options %s', JSON.stringify(options, null, 2)); - return mailer.sendSimple(options); }) .then(() => { - - debug('password reset email sent successfully'); - // we want to send a 204 regardless of the user being found in the db // if we fail on missing emails, it would reveal if people are registered or not. res.status(204).end(); }) .catch(error => { const errorMsg = typeof error === 'string' ? error : error.message; - - debug('there was an error sending your email %s', error); - res.status(500).json({error: errorMsg}); }); });