From 978e1c8d4ceae38e8b3f74622661dee0cf3ab9d2 Mon Sep 17 00:00:00 2001
From: Wyatt Johnson <wyattjoh@gmail.com>
Date: Mon, 8 Jan 2018 11:04:29 -0700
Subject: [PATCH] fix to optional required param

---
 config.js          | 26 +-------------------------
 services/mailer.js |  1 -
 2 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/config.js b/config.js
index 954d7a8df..6379b08f0 100644
--- a/config.js
+++ b/config.js
@@ -343,9 +343,7 @@ CONFIG.REDIS_CLIENT_CONFIG = JSON.parse(CONFIG.REDIS_CLIENT_CONFIG);
  */
 CONFIG.RECAPTCHA_ENABLED =
   CONFIG.RECAPTCHA_SECRET &&
-  CONFIG.RECAPTCHA_SECRET.length > 0 &&
-  CONFIG.RECAPTCHA_PUBLIC &&
-  CONFIG.RECAPTCHA_PUBLIC.length > 0;
+  CONFIG.RECAPTCHA_PUBLIC;
 
 debug(
   `reCAPTCHA is ${
@@ -355,26 +353,4 @@ debug(
   }`
 );
 
-//------------------------------------------------------------------------------
-// SMTP Server configuration
-//------------------------------------------------------------------------------
-
-CONFIG.EMAIL_ENABLED =
-  CONFIG.SMTP_FROM_ADDRESS &&
-  CONFIG.SMTP_FROM_ADDRESS.length > 0 &&
-  CONFIG.SMTP_USERNAME &&
-  CONFIG.SMTP_USERNAME.length > 0 &&
-  CONFIG.SMTP_PASSWORD &&
-  CONFIG.SMTP_PASSWORD.length > 0 &&
-  CONFIG.SMTP_HOST &&
-  CONFIG.SMTP_HOST.length > 0;
-
-debug(
-  `Email is ${
-    CONFIG.EMAIL_ENABLED
-      ? 'enabled'
-      : 'disabled, required config is not present'
-  }`
-);
-
 module.exports = CONFIG;
diff --git a/services/mailer.js b/services/mailer.js
index 08f1d6c29..f66fd8240 100644
--- a/services/mailer.js
+++ b/services/mailer.js
@@ -54,7 +54,6 @@ const mailer = {};
 mailer.enabled = Boolean(
   SMTP_HOST &&
   SMTP_USERNAME &&
-  SMTP_PORT &&
   SMTP_PASSWORD &&
   SMTP_FROM_ADDRESS
 ) || process.env.NODE_ENV === 'test';