fixing and separating broken tests /client /server

test/server/routes/api/account/index.js

@@ -0,0 +1,71 @@
+const passport = require('../../../passport');
+
+const app = require('../../../../../app');
+const chai = require('chai');
+const expect = chai.expect;
+
+const SettingsService = require('../../../../../services/settings');
+const settings = {id: '1', moderation: 'PRE', wordlist: {banned: ['bad words'], suspect: ['suspect words']}};
+
+// Setup chai.
+chai.should();
+chai.use(require('chai-http'));
+
+const UsersService = require('../../../../../services/users');
+
+describe('/api/v1/account/username', () => {
+  let mockUser;
+
+  beforeEach(() => SettingsService.init(settings).then(() => {
+    return UsersService.createLocalUser('ana@gmail.com', '123321123', 'Ana');
+  })
+  .then((user) => {
+    mockUser = user;
+  }));
+
+  describe('#put', () => {
+    it('it should enable a user to edit their username if canEditName is enabled', () => {
+      return chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/username-enable`)
+        .set(passport.inject({id: '456', roles: ['ADMIN']}))
+        .then(() => chai.request(app)
+          .put('/api/v1/account/username')
+          .set(passport.inject({id: mockUser.id, roles: []}))
+          .send({username: 'MojoJojo'}))
+        .then((res) => {
+          expect(res).to.have.status(204);
+        });
+    });
+
+    it('it should return an error if the wrong user tries to edit a username', (done) => {
+      chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/username-enable`)
+        .set(passport.inject({id: '456', roles: ['ADMIN']}))
+        .then(() => chai.request(app)
+          .put('/api/v1/account/username')
+          .set(passport.inject({id: 'wrongid', roles: []}))
+          .send({username: 'MojoJojo'}))
+        .then(() => {
+          done(new Error('Exected Error'));
+        })
+        .catch((err) => {
+          expect(err).to.be.truthy;
+          done();
+        });
+    });
+
+    it('it should return an error when the user tries to edit their username if canEditName is disabled', (done) => {
+      chai.request(app)
+        .put('/api/v1/account/username')
+        .set(passport.inject({id: mockUser.id, roles: []}))
+        .send({username: 'MojoJojo'})
+        .then(() => {
+          done(new Error('Exected Error'));
+        })
+        .catch((err) => {
+          expect(err).to.be.truthy;
+          done();
+        });
+    });
+  });
+});

test/server/routes/api/assets/index.js

@@ -0,0 +1,153 @@
+const passport = require('../../../passport');
+
+const app = require('../../../../../app');
+const chai = require('chai');
+const expect = chai.expect;
+
+// Setup chai.
+chai.should();
+chai.use(require('chai-http'));
+
+const AssetModel = require('../../../../../models/asset');
+const AssetsService = require('../../../../../services/assets');
+const SettingsService = require('../../../../../services/settings');
+
+describe('/api/v1/assets', () => {
+
+  beforeEach(() => {
+    const settings = {id: '1', moderation: 'PRE', domains: {whitelist: ['test.com']}};
+
+    return SettingsService.init(settings).then(() => {
+      return AssetModel.create([
+        {
+          url: 'https://coralproject.net/news/asset1',
+          title: 'Asset 1',
+          description: 'term1',
+          closedAt: Date.now()
+        },
+        {
+          url: 'https://coralproject.net/news/asset2',
+          title: 'Asset 2',
+          description: 'term2',
+          closedAt: null
+        }
+      ]);
+    });
+  });
+
+  describe('#get', () => {
+
+    it('should return all assets without a search query', () => {
+      return chai.request(app)
+        .get('/api/v1/assets')
+        .set(passport.inject({roles: ['ADMIN']}))
+        .then((res) => {
+          const body = res.body;
+
+          expect(body).to.have.property('count', 2);
+          expect(body).to.have.property('result');
+
+          const assets = body.result;
+
+          expect(assets).to.have.length(2);
+        });
+    });
+
+    it('should return assets that we search for', () => {
+      return chai.request(app)
+        .get('/api/v1/assets?search=term2')
+        .set(passport.inject({roles: ['ADMIN']}))
+        .then((res) => {
+          const body = res.body;
+
+          expect(body).to.have.property('count', 1);
+          expect(body).to.have.property('result');
+
+          const assets = body.result;
+
+          expect(assets).to.have.length(1);
+
+          const asset = assets[0];
+
+          expect(asset).to.have.property('url', 'https://coralproject.net/news/asset2');
+          expect(asset).to.have.property('title', 'Asset 2');
+        });
+    });
+
+    it('should not return assets that we do not search for', () => {
+      return chai.request(app)
+        .get('/api/v1/assets?search=term3')
+        .set(passport.inject({roles: ['ADMIN']}))
+        .then((res) => {
+          const body = res.body;
+
+          expect(body).to.have.property('count', 0);
+          expect(body).to.have.property('result');
+
+          expect(body.result).to.be.empty;
+        });
+    });
+
+    it('should return only closed assets', () => {
+      return chai.request(app)
+        .get('/api/v1/assets?filter=closed')
+        .set(passport.inject({roles: ['ADMIN']}))
+        .then((res) => {
+          const body = res.body;
+
+          expect(body).to.have.property('count', 1);
+          expect(body).to.have.property('result');
+
+          const assets = body.result;
+
+          expect(assets[0]).to.have.property('title', 'Asset 1');
+        });
+    });
+
+    it('should return only opened assets', () => {
+      return chai.request(app)
+        .get('/api/v1/assets?filter=open')
+        .set(passport.inject({roles: ['ADMIN']}))
+        .then((res) => {
+          const body = res.body;
+
+          expect(body).to.have.property('count', 1);
+          expect(body).to.have.property('result');
+
+          const assets = body.result;
+
+          expect(assets[0]).to.have.property('title', 'Asset 2');
+        });
+    });
+
+  });
+
+  describe('#put', () => {
+    it('should close the asset', function() {
+
+      const today = Date.now();
+
+      return AssetsService.findOrCreateByUrl('http://test.com')
+        .then((asset) => {
+          expect(asset).to.have.property('isClosed', null);
+          expect(asset).to.have.property('closedAt', null);
+
+          return chai.request(app)
+            .put(`/api/v1/assets/${asset.id}/status`)
+            .set(passport.inject({roles: ['ADMIN']}))
+            .send({closedAt: today});
+        })
+        .then((res) => {
+
+          expect(res).to.have.status(204);
+
+          return AssetsService.findByUrl('http://test.com');
+        })
+        .then((asset) => {
+          expect(asset).to.have.property('isClosed', true);
+          expect(asset).to.have.property('closedAt').and.to.not.equal(null);
+        });
+    });
+  });
+
+});

test/server/routes/api/auth/index.js

@@ -0,0 +1,99 @@
+const app = require('../../../../../app');
+const chai = require('chai');
+const expect = chai.expect;
+
+chai.use(require('chai-http'));
+
+const UsersService = require('../../../../../services/users');
+
+describe('/api/v1/auth', () => {
+  describe('#get', () => {
+    it('should return nothing when no user is logged in', () => {
+      return chai.request(app)
+        .get('/api/v1/auth')
+        .then((res) => {
+          expect(res.status).to.be.equal(204);
+          expect(res).to.not.have.a.body;
+        });
+    });
+  });
+});
+
+const SettingsService = require('../../../../../services/settings');
+
+describe('/api/v1/auth/local', () => {
+
+  let mockUser;
+  beforeEach(() => {
+    const settings = {requireEmailConfirmation: false, wordlist: {banned: ['bad'], suspect: ['naughty']}};
+    return SettingsService.init(settings).then(() => {
+      return UsersService.createLocalUser('maria@gmail.com', 'password!', 'Maria')
+        .then((user) => {
+          mockUser = user;
+        });
+    });
+  });
+
+  describe('email confirmation disabled', () => {
+
+    describe('#post', () => {
+      it('should send back the user on a successful login', () => {
+        return chai.request(app)
+          .post('/api/v1/auth/local')
+          .send({email: 'maria@gmail.com', password: 'password!'})
+          .then((res2) => {
+            expect(res2).to.have.status(200);
+            expect(res2).to.be.json;
+            expect(res2.body).to.have.property('user');
+            expect(res2.body.user).to.have.property('username', 'Maria');
+          });
+      });
+
+      it('should not send back the user on a unsuccessful login', () => {
+        return chai.request(app)
+          .post('/api/v1/auth/local')
+            .send({email: 'maria@gmail.com', password: 'password!3'})
+            .catch((err) => {
+              expect(err).to.not.be.null;
+              expect(err.response).to.have.status(401);
+              expect(err.response.body).to.have.property('message', 'not authorized');
+            });
+      });
+
+    });
+
+  });
+
+  describe('email confirmation enabled', () => {
+
+    beforeEach(() => SettingsService.update({requireEmailConfirmation: true}));
+
+    describe('#post', () => {
+      it('should not allow a login from a user that is not confirmed', () => {
+        return chai.request(app)
+          .post('/api/v1/auth/local')
+          .send({email: 'maria@gmail.com', password: 'password!'})
+          .catch((err) => {
+            expect(err).to.have.status(401);
+            err.response.body.should.have.property('error');
+            err.response.body.error.should.have.property('metadata');
+            err.response.body.error.metadata.should.have.property('message', 'maria@gmail.com');
+
+            return UsersService.createEmailConfirmToken(mockUser.id, mockUser.profiles[0].id);
+          })
+          .then(UsersService.verifyEmailConfirmation)
+          .then(() => {
+            return chai.request(app)
+              .post('/api/v1/auth/local')
+              .send({email: 'maria@gmail.com', password: 'password!'});
+          })
+          .then((res) => {
+            expect(res).to.have.status(200);
+            expect(res).to.be.json;
+            expect(res.body).to.have.property('user');
+            expect(res.body.user).to.have.property('username', 'Maria');
+          });
+      });
+    });
+  });
+});

test/server/routes/api/settings/index.js

@@ -0,0 +1,51 @@
+const passport = require('../../../passport');
+
+const app = require('../../../../../app');
+const chai = require('chai');
+const expect = chai.expect;
+
+chai.should();
+chai.use(require('chai-http'));
+
+const SettingsService = require('../../../../../services/settings');
+const defaults = {id: '1', moderation: 'PRE'};
+
+describe('/api/v1/settings', () => {
+
+  beforeEach(() => SettingsService.init(defaults));
+
+  describe('#get', () => {
+
+    it('should return a settings object', () => {
+      return chai.request(app)
+        .get('/api/v1/settings')
+        .set(passport.inject({
+          roles: ['ADMIN']
+        }))
+        .then((res) => {
+          expect(res).to.have.status(200);
+          expect(res).to.be.json;
+          expect(res.body).to.have.property('moderation', 'PRE');
+        });
+    });
+  });
+
+  describe('#put', () => {
+
+    it('should update the settings', () => {
+      return chai.request(app)
+        .put('/api/v1/settings')
+        .set(passport.inject({roles: ['ADMIN']}))
+        .send({moderation: 'POST'})
+        .then((res) => {
+          expect(res).to.have.status(204);
+
+          return SettingsService.retrieve();
+        })
+        .then((settings) => {
+          expect(settings).to.have.property('moderation', 'POST');
+        });
+    });
+  });
+
+});

test/server/routes/api/user/index.js

@@ -0,0 +1,100 @@
+const passport = require('../../../passport');
+
+const app = require('../../../../../app');
+const mailer = require('../../../../../services/mailer');
+const chai = require('chai');
+const expect = chai.expect;
+
+const SettingsService = require('../../../../../services/settings');
+const settings = {id: '1', moderation: 'PRE', wordlist: {banned: ['bad words'], suspect: ['suspect words']}};
+
+// Setup chai.
+chai.should();
+chai.use(require('chai-http'));
+
+const UsersService = require('../../../../../services/users');
+
+describe('/api/v1/users/:user_id/email/confirm', () => {
+
+  let mockUser;
+
+  beforeEach(() => SettingsService.init(settings).then(() => {
+    return UsersService.createLocalUser('ana@gmail.com', '123321123', 'Ana');
+  })
+  .then((user) => {
+    mockUser = user;
+  }));
+
+  describe('#post', () => {
+    it('should send an email when we hit the endpoint', () => {
+      expect(mailer.task.tasks).to.have.length(0);
+
+      return chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/email/confirm`)
+        .set(passport.inject({roles: ['ADMIN']}))
+        .then((res) => {
+          expect(res).to.have.status(204);
+          expect(mailer.task.tasks).to.have.length(1);
+        });
+    });
+
+    it('should send a 404 on not matching a user', () => {
+      return chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/email/confirm`)
+        .set(passport.inject({roles: ['ADMIN']}))
+        .then((res) => {
+          expect(res).to.have.status(204);
+          expect(mailer.task.tasks).to.have.length(1);
+        });
+    });
+  });
+});
+
+describe('/api/v1/users/:user_id/actions', () => {
+
+  let mockUser;
+
+  beforeEach(() => SettingsService.init(settings).then(() => {
+    return UsersService.createLocalUser('ana@gmail.com', '123321123', 'Ana');
+  })
+  .then((user) => {
+    mockUser = user;
+  }));
+
+  describe('#post', () => {
+    it('it should update actions', () => {
+      return chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/actions`)
+        .set(passport.inject({id: '456', roles: ['ADMIN']}))
+        .send({'action_type': 'FLAG', metadata: {reason: 'Bio is too awesome.'}})
+        .then((res) => {
+          expect(res).to.have.status(201);
+          expect(res).to.have.body;
+          expect(res.body).to.have.property('action_type', 'FLAG');
+          expect(res.body).to.have.property('item_id', mockUser.id);
+        });
+    });
+  });
+});
+
+describe('/api/v1/users/:user_id/username-enable', () => {
+  let mockUser;
+
+  beforeEach(() => SettingsService.init(settings).then(() => {
+    return UsersService.createLocalUser('ana@gmail.com', '123321123', 'Ana');
+  })
+  .then((user) => {
+    mockUser = user;
+  }));
+
+  describe('#post', () => {
+    it('it should enable a user to edit their username', () => {
+      return chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/username-enable`)
+        .set(passport.inject({id: '456', roles: ['ADMIN']}))
+        .then((res) => {
+          expect(res).to.have.status(204);
+        });
+    });
+  });
+});