diff --git a/src/core/client/framework/lib/messages.tsx b/src/core/client/framework/lib/messages.tsx index c8234c670..316cd6e8a 100644 --- a/src/core/client/framework/lib/messages.tsx +++ b/src/core/client/framework/lib/messages.tsx @@ -13,7 +13,7 @@ export const VALIDATION_REQUIRED = () => ( ); export const VALIDATION_TOO_SHORT = () => ( - + This field is too short. ); diff --git a/src/core/client/stream/components/PostCommentForm.tsx b/src/core/client/stream/components/PostCommentForm.tsx index 018cc71dd..09db70e39 100644 --- a/src/core/client/stream/components/PostCommentForm.tsx +++ b/src/core/client/stream/components/PostCommentForm.tsx @@ -40,7 +40,7 @@ const PostCommentForm: StatelessComponent = props => ( )}
- + diff --git a/src/core/client/stream/components/ReplyList.spec.tsx b/src/core/client/stream/components/ReplyList.spec.tsx index 514dab24c..12b673732 100644 --- a/src/core/client/stream/components/ReplyList.spec.tsx +++ b/src/core/client/stream/components/ReplyList.spec.tsx @@ -32,7 +32,9 @@ describe("when there is more", () => { }); it("calls onLoadMore", () => { - wrapper.find("#talk-reply-list--show-all--comment-id").simulate("click"); + wrapper + .find("#talk-comments-replyList-showAll--comment-id") + .simulate("click"); expect((props.onShowAll as SinonSpy).calledOnce).toBe(true); }); }); diff --git a/src/core/client/stream/components/ReplyList.tsx b/src/core/client/stream/components/ReplyList.tsx index c712c4124..ec366771c 100644 --- a/src/core/client/stream/components/ReplyList.tsx +++ b/src/core/client/stream/components/ReplyList.tsx @@ -1,3 +1,4 @@ +import { Localized } from "fluent-react/compat"; import * as React from "react"; import { StatelessComponent } from "react"; @@ -17,22 +18,24 @@ export interface ReplyListProps { const ReplyList: StatelessComponent = props => { return ( -
+
{props.comments.map(comment => ( ))} {props.hasMore && ( - + + + )}
diff --git a/src/core/client/stream/components/Stream.spec.tsx b/src/core/client/stream/components/Stream.spec.tsx index 37c51ac23..5d9c81bdf 100644 --- a/src/core/client/stream/components/Stream.spec.tsx +++ b/src/core/client/stream/components/Stream.spec.tsx @@ -47,7 +47,7 @@ describe("when there is more", () => { }); it("calls onLoadMore", () => { - wrapper.find("#talk-stream--load-more").simulate("click"); + wrapper.find("#talk-comments-stream-loadMore").simulate("click"); expect(props.onLoadMore.calledOnce).toBe(true); }); diff --git a/src/core/client/stream/components/Stream.tsx b/src/core/client/stream/components/Stream.tsx index e1dc28231..87f0670dd 100644 --- a/src/core/client/stream/components/Stream.tsx +++ b/src/core/client/stream/components/Stream.tsx @@ -1,3 +1,4 @@ +import { Localized } from "fluent-react/compat"; import * as React from "react"; import { StatelessComponent } from "react"; @@ -26,7 +27,7 @@ const Stream: StatelessComponent = props => {
-
+
{props.comments.map(comment => (
@@ -34,17 +35,19 @@ const Stream: StatelessComponent = props => {
))} {props.hasMore && ( - + + + )}
diff --git a/src/core/client/stream/components/__snapshots__/ReplyList.spec.tsx.snap b/src/core/client/stream/components/__snapshots__/ReplyList.spec.tsx.snap index f049fede4..36fb0c110 100644 --- a/src/core/client/stream/components/__snapshots__/ReplyList.spec.tsx.snap +++ b/src/core/client/stream/components/__snapshots__/ReplyList.spec.tsx.snap @@ -2,56 +2,71 @@ exports[`renders correctly 1`] = ` - + - + + gutterBottom={true} + key="comment-2" + /> +
`; exports[`when there is more renders a load more button 1`] = ` - - - - Show All Replies - + + + + + Show All Replies + + +
`; diff --git a/src/core/client/stream/components/__snapshots__/Stream.spec.tsx.snap b/src/core/client/stream/components/__snapshots__/Stream.spec.tsx.snap index 9abf71e5e..6283dab2e 100644 --- a/src/core/client/stream/components/__snapshots__/Stream.spec.tsx.snap +++ b/src/core/client/stream/components/__snapshots__/Stream.spec.tsx.snap @@ -9,42 +9,48 @@ exports[`renders correctly 1`] = ` assetID="asset-id" />
- + - + -
-
- +
+
+ - + + /> +
`; @@ -64,53 +70,64 @@ exports[`when there is more disables load more button 1`] = ` assetID="asset-id" />
- + - + + /> +
+
+ + +
+ + + Load More + + -
- - -
- - Load More - `; @@ -123,52 +140,63 @@ exports[`when there is more renders a load more button 1`] = ` assetID="asset-id" />
- + - + + /> +
+
+ + +
+ + + Load More + + -
- - -
- - Load More - `; diff --git a/src/core/client/stream/test/__snapshots__/loadMore.spec.tsx.snap b/src/core/client/stream/test/__snapshots__/loadMore.spec.tsx.snap index 2ce30f68c..8b37696d2 100644 --- a/src/core/client/stream/test/__snapshots__/loadMore.spec.tsx.snap +++ b/src/core/client/stream/test/__snapshots__/loadMore.spec.tsx.snap @@ -36,52 +36,73 @@ exports[`loads more comments 1`] = ` -
-
-

+
+
- Markus -

-

- Joining Too -

+
+ + Markus + +
+

+ Joining Too +

+
- -
-
-

+
- Lukas -

-

- What's up? -

+
+ + Lukas + +
+

+ What's up? +

+
- -
-
-

+
- Isabelle -

-

- Hey! -

+
+ + Isabelle + +
+

+ Hey! +

+
@@ -124,49 +145,66 @@ exports[`renders comment stream 1`] = ` -
-
-

- Markus -

-

- Joining Too -

-
-
-
-
-

- Lukas -

-

- What's up? -

-
-
- +
+
+
+ + Markus + +
+

+ Joining Too +

+
+
+
+
+
+ + Lukas + +
+

+ What's up? +

+
+
+ + `; diff --git a/src/core/client/stream/test/__snapshots__/renderReplies.spec.tsx.snap b/src/core/client/stream/test/__snapshots__/renderReplies.spec.tsx.snap index 318774c4c..6a9e97905 100644 --- a/src/core/client/stream/test/__snapshots__/renderReplies.spec.tsx.snap +++ b/src/core/client/stream/test/__snapshots__/renderReplies.spec.tsx.snap @@ -36,68 +36,99 @@ exports[`renders comment stream 1`] = ` -
-
-

- Markus -

-

- Joining Too -

-
-
-
-
-

- Markus -

-

- I like yoghurt -

-
-
+
+
-

- Markus -

+ + Markus + +

Joining Too

+
+
-

- Lukas -

+ + Markus + +

- What's up? + I like yoghurt

+
+
+
+
+ + Markus + +
+

+ Joining Too +

+
+
+
+ + Lukas + +
+

+ What's up? +

+
+
+
diff --git a/src/core/client/stream/test/__snapshots__/renderStream.spec.tsx.snap b/src/core/client/stream/test/__snapshots__/renderStream.spec.tsx.snap index e91837858..0090dd145 100644 --- a/src/core/client/stream/test/__snapshots__/renderStream.spec.tsx.snap +++ b/src/core/client/stream/test/__snapshots__/renderStream.spec.tsx.snap @@ -36,36 +36,52 @@ exports[`renders comment stream 1`] = ` -
-
-

+
+
- Markus -

-

- Joining Too -

+
+ + Markus + +
+

+ Joining Too +

+
- -
-
-

+
- Lukas -

-

- What's up? -

+
+ + Lukas + +
+

+ What's up? +

+
diff --git a/src/core/client/stream/test/__snapshots__/showAllReplies.spec.tsx.snap b/src/core/client/stream/test/__snapshots__/showAllReplies.spec.tsx.snap index 6d3a962ce..2ee40a6ae 100644 --- a/src/core/client/stream/test/__snapshots__/showAllReplies.spec.tsx.snap +++ b/src/core/client/stream/test/__snapshots__/showAllReplies.spec.tsx.snap @@ -36,49 +36,71 @@ exports[`renders comment stream 1`] = ` -
-
-

- Markus -

-

- Joining Too -

-
-
+
+
-

- Lukas -

+ + Markus + +

- What's up? + Joining Too

- +
+
+
+ + Lukas + +
+

+ What's up? +

+
+ +
+
@@ -121,51 +143,77 @@ exports[`show all replies 1`] = ` -
-
-

- Markus -

-

- Joining Too -

-
-
+
+
-

- Lukas -

+ + Markus + +

- What's up? + Joining Too

-

- Isabelle -

-

- Hey! -

+
+
+ + Lukas + +
+

+ What's up? +

+
+
+
+ + Isabelle + +
+

+ Hey! +

+
+
diff --git a/src/core/client/stream/test/loadMore.spec.tsx b/src/core/client/stream/test/loadMore.spec.tsx index fdc901f4a..6f63edcfc 100644 --- a/src/core/client/stream/test/loadMore.spec.tsx +++ b/src/core/client/stream/test/loadMore.spec.tsx @@ -89,7 +89,7 @@ it("renders comment stream", async () => { it("loads more comments", async () => { testRenderer.root - .findByProps({ id: "talk-stream--load-more" }) + .findByProps({ id: "talk-comments-stream-loadMore" }) .props.onClick(); // Wait for loading. diff --git a/src/core/client/stream/test/showAllReplies.spec.tsx b/src/core/client/stream/test/showAllReplies.spec.tsx index a3802c49e..3e929b5b0 100644 --- a/src/core/client/stream/test/showAllReplies.spec.tsx +++ b/src/core/client/stream/test/showAllReplies.spec.tsx @@ -105,7 +105,7 @@ it("renders comment stream", async () => { it("show all replies", async () => { testRenderer.root - .findByProps({ id: `talk-reply-list--show-all--${comments[0].id}` }) + .findByProps({ id: `talk-comments-replyList-showAll--${comments[0].id}` }) .props.onClick(); // Wait for loading. diff --git a/src/locales/de/framework.ftl b/src/locales/de/framework.ftl index fbb6cb340..bd604bf67 100644 --- a/src/locales/de/framework.ftl +++ b/src/locales/de/framework.ftl @@ -2,4 +2,6 @@ ### All keys must start with `framework` because this file is shared ### among different targets. +## Validation + framework-validation-required = Dies ist ein Pflichtpfeld. diff --git a/src/locales/de/stream.ftl b/src/locales/de/stream.ftl index d8f1f5f11..c4eb3040a 100644 --- a/src/locales/de/stream.ftl +++ b/src/locales/de/stream.ftl @@ -1 +1,7 @@ -postCommentForm-submit = Posten +### Localization for Embed Stream + +## Comments Tab + +comments-postCommentForm-post = Posten +comments-stream-loadMore = Mehr laden +comments-replyList-showAll = Alle anzeigen diff --git a/src/locales/en-US/framework.ftl b/src/locales/en-US/framework.ftl index d50f28b07..1285552cd 100644 --- a/src/locales/en-US/framework.ftl +++ b/src/locales/en-US/framework.ftl @@ -2,4 +2,6 @@ ### All keys must start with `framework` because this file is shared ### among different targets. +## Validation + framework-validation-required = This field is required. diff --git a/src/locales/en-US/stream.ftl b/src/locales/en-US/stream.ftl index 4d79869a5..439e8955a 100644 --- a/src/locales/en-US/stream.ftl +++ b/src/locales/en-US/stream.ftl @@ -1 +1,7 @@ -postCommentForm-submit = Post +### Localization for Embed Stream + +## Comments Tab + +comments-postCommentForm-post = Post +comments-stream-loadMore = Load more +comments-replyList-showAll = Show all