From 37e39ff8c500d6a8eacd6a2060c333cece0d06f8 Mon Sep 17 00:00:00 2001
From: Cristian Dean <cristian.dean@corp.globo.com>
Date: Mon, 23 Sep 2019 18:26:47 -0300
Subject: [PATCH] Avoid compute metrics with 404 status code (#2587)

---
 src/core/server/app/middleware/metrics.ts | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/core/server/app/middleware/metrics.ts b/src/core/server/app/middleware/metrics.ts
index a5546f92a..e472c51e3 100644
--- a/src/core/server/app/middleware/metrics.ts
+++ b/src/core/server/app/middleware/metrics.ts
@@ -20,12 +20,14 @@ export const metricsRecorder = ({
       // Increment the request counter.
       httpRequestsTotal.labels(`${res.statusCode}`, req.method).inc();
 
-      // Add the request duration.
-      httpRequestDurationMilliseconds
-        .labels(req.method, req.baseUrl + req.path)
-        .observe(responseTime);
+      // Only compute the request path when status code isn't 404 to avoid flood
+      if (res.statusCode !== 404) {
+        // Add the request duration.
+        httpRequestDurationMilliseconds
+          .labels(req.method, req.baseUrl + req.path)
+          .observe(responseTime);
+      }
     });
-
     next();
   };
 };