From 3a4eae87adece7810f85416d7d57fb823b413dfc Mon Sep 17 00:00:00 2001 From: Wyatt Johnson Date: Wed, 2 Oct 2019 16:21:49 +0000 Subject: [PATCH] [CORL-661] Encode Story ID (#2614) * fix: encode story ID's for URL * fix: use shared method --- src/core/client/admin/helpers/getModerationLink.ts | 2 +- .../Moderate/ModerateSearchBar/ModerateSearchBarContainer.tsx | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/core/client/admin/helpers/getModerationLink.ts b/src/core/client/admin/helpers/getModerationLink.ts index 6fe59ca2b..a8707b1e0 100644 --- a/src/core/client/admin/helpers/getModerationLink.ts +++ b/src/core/client/admin/helpers/getModerationLink.ts @@ -5,6 +5,6 @@ export default function getModerationLink( storyID?: string | null ) { const queuePart = queue && queue !== "default" ? `/${queue}` : ""; - const storyPart = storyID ? `/${storyID}` : ""; + const storyPart = storyID ? `/${encodeURIComponent(storyID)}` : ""; return `${basePath}${queuePart}${storyPart}`; } diff --git a/src/core/client/admin/routes/Moderate/ModerateSearchBar/ModerateSearchBarContainer.tsx b/src/core/client/admin/routes/Moderate/ModerateSearchBar/ModerateSearchBarContainer.tsx index e2fa37afd..28eace977 100644 --- a/src/core/client/admin/routes/Moderate/ModerateSearchBar/ModerateSearchBarContainer.tsx +++ b/src/core/client/admin/routes/Moderate/ModerateSearchBar/ModerateSearchBarContainer.tsx @@ -10,6 +10,7 @@ import React, { import { graphql } from "react-relay"; import { ModerateSearchBarContainer_story as ModerationQueuesData } from "coral-admin/__generated__/ModerateSearchBarContainer_story.graphql"; +import { getModerationLink } from "coral-admin/helpers"; import { useEffectWhenChanged } from "coral-framework/hooks"; import { useFetch, withFragmentContainer } from "coral-framework/lib/relay"; import { PropTypesOf } from "coral-framework/types"; @@ -160,7 +161,7 @@ function useSearchOptions( nextSearchOptions.push({ element: (