From 42d4abf8426b499bc9722c7ac1a2ea5f29b7fc2c Mon Sep 17 00:00:00 2001
From: Wyatt Johnson <wyattjoh@gmail.com>
Date: Fri, 11 May 2018 09:33:18 -0600
Subject: [PATCH] review updates

---
 plugins/talk-plugin-local-auth/client/actions.js            | 2 +-
 .../client/components/AddEmailAddressDialog.js              | 6 ++++--
 plugins/talk-plugin-local-auth/client/constants.js          | 2 +-
 plugins/talk-plugin-local-auth/client/reducer.js            | 2 +-
 plugins/talk-plugin-local-auth/translations.yml             | 1 +
 5 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/plugins/talk-plugin-local-auth/client/actions.js b/plugins/talk-plugin-local-auth/client/actions.js
index 9f2c9cfed..972e1f6fd 100644
--- a/plugins/talk-plugin-local-auth/client/actions.js
+++ b/plugins/talk-plugin-local-auth/client/actions.js
@@ -1,7 +1,7 @@
 import * as actions from './constants';
 
 export const startAttach = () => ({
-  type: actions.STARTED_ATTACH,
+  type: actions.START_ATTACH,
 });
 
 export const finishAttach = () => ({
diff --git a/plugins/talk-plugin-local-auth/client/components/AddEmailAddressDialog.js b/plugins/talk-plugin-local-auth/client/components/AddEmailAddressDialog.js
index 76131c895..a5bfd7096 100644
--- a/plugins/talk-plugin-local-auth/client/components/AddEmailAddressDialog.js
+++ b/plugins/talk-plugin-local-auth/client/components/AddEmailAddressDialog.js
@@ -124,8 +124,10 @@ class AddEmailAddressDialog extends React.Component {
         password: confirmPassword,
       });
 
-      // TODO: translate
-      this.props.notify('success', 'Email Added!');
+      this.props.notify(
+        'success',
+        t('talk-plugin-local-auth.add_email.added.alert')
+      );
       this.goToNextStep();
     } catch (err) {
       this.props.notify('error', getErrorMessages(err));
diff --git a/plugins/talk-plugin-local-auth/client/constants.js b/plugins/talk-plugin-local-auth/client/constants.js
index 86f5242f7..d410a10fa 100644
--- a/plugins/talk-plugin-local-auth/client/constants.js
+++ b/plugins/talk-plugin-local-auth/client/constants.js
@@ -1,4 +1,4 @@
 const prefix = 'TALK_LOCAL_AUTH';
 
-export const STARTED_ATTACH = `${prefix}_STARTED_ATTACH`;
+export const START_ATTACH = `${prefix}_START_ATTACH`;
 export const FINISH_ATTACH = `${prefix}_FINISH_ATTACH`;
diff --git a/plugins/talk-plugin-local-auth/client/reducer.js b/plugins/talk-plugin-local-auth/client/reducer.js
index 403a84814..11666e505 100644
--- a/plugins/talk-plugin-local-auth/client/reducer.js
+++ b/plugins/talk-plugin-local-auth/client/reducer.js
@@ -6,7 +6,7 @@ const initialState = {
 
 export default function reducer(state = initialState, action) {
   switch (action.type) {
-    case actions.STARTED_ATTACH:
+    case actions.START_ATTACH:
       return {
         inProgress: true,
       };
diff --git a/plugins/talk-plugin-local-auth/translations.yml b/plugins/talk-plugin-local-auth/translations.yml
index 7180268ea..5fd2264e6 100644
--- a/plugins/talk-plugin-local-auth/translations.yml
+++ b/plugins/talk-plugin-local-auth/translations.yml
@@ -67,6 +67,7 @@ en:
         subtitle: "Need to change your email address?"
         description_2: "You can change your account settings by visiting"
         path: "My Profile > Settings"
+        alert: "Email Added!"
 es:
   talk-plugin-local-auth:
     change_password: