wassname/talk
1
0
Fork 0
mirror of https://github.com/wassname/talk.git synced 2026-08-17 11:27:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

[CORL-239, CORL-128] Support disabled commenting and closed stories in Stream (#2205)

Browse Source 
* feat: closed story + disabled commenting

* test: add feature test and fix bugs

* fix: snapshot

* fix: isClosed can't be null

* fix: remove duplicate DeepPartial type

* fix: border color
This commit is contained in:
Kiwi
2019-03-04 23:27:46 +01:00
committed by GitHub
parent 625809b42c
commit 4e043638f6
52 changed files with 1974 additions and 1246 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/server/services/comments/pipeline/phases/commentingDisabled.ts
+2 -2
View File
@@ -1,3 +1,4 @@
import { CommentingDisabledError } from "talk-server/errors";
import { ModerationSettings } from "talk-server/models/settings";
import {
IntermediateModerationPhase,
@@ -16,7 +17,6 @@ export const commentingDisabled: IntermediateModerationPhase = ({
testDisabledCommenting(tenant) ||
(story.settings && testDisabledCommenting(story.settings))
) {
// TODO: (wyattjoh) return better error.
throw new Error("commenting has been disabled tenant wide");
throw new CommentingDisabledError();
}
};
src/core/server/services/comments/pipeline/phases/storyClosed.ts
+2 -2
View File
@@ -1,3 +1,4 @@
import { StoryClosedError } from "talk-server/errors";
import {
IntermediateModerationPhase,
IntermediatePhaseResult,
@@ -11,7 +12,6 @@ export const storyClosed: IntermediateModerationPhase = ({
}): IntermediatePhaseResult | void => {
const closedAt = getStoryClosedAt(tenant, story);
if (closedAt && closedAt.valueOf() <= Date.now()) {
// TODO: (wyattjoh) return better error.
throw new Error("story is currently closed for commenting");
throw new StoryClosedError();
}
};