From 4fc305ebff6724fe3963309f6181944ecd2453e9 Mon Sep 17 00:00:00 2001
From: Wyatt Johnson <wyattjoh@gmail.com>
Date: Thu, 23 Nov 2017 13:49:36 -0700
Subject: [PATCH] fixes based on feedback

---
 services/users.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/services/users.js b/services/users.js
index 10d3a3ecd..ada293874 100644
--- a/services/users.js
+++ b/services/users.js
@@ -53,10 +53,6 @@ class UsersService {
    * Returns a user (if found) for the given email address.
    */
   static findLocalUser(email) {
-    if (!email || typeof email !== 'string') {
-      return Promise.reject('email is required for findLocalUser');
-    }
-
     return UserModel.findOne({
       profiles: {
         $elemMatch: {
@@ -111,6 +107,9 @@ class UsersService {
         throw errors.ErrNotFound;
       }
 
+      // Date comparisons are difficult when using MongoDB. Javascript will
+      // store the date at a higher precision than Mongo can store, hence we
+      // check if the date is within 1 second of the time we're trying to set.
       if (
         user.status.suspension.until === until ||
         (
@@ -149,7 +148,8 @@ class UsersService {
         }
       }
     }, {
-      new: true
+      new: true,
+      runValidators: true
     });
     if (user === null) {
       user = await UserModel.findOne({id});