From f7d1543aa321bf403768eac4b1032cff08d40225 Mon Sep 17 00:00:00 2001 From: Wyatt Johnson Date: Mon, 18 Dec 2017 10:24:11 -0700 Subject: [PATCH 1/3] fixes for sorted window handler --- test/e2e/utils/SortedWindowHandler.js | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/test/e2e/utils/SortedWindowHandler.js b/test/e2e/utils/SortedWindowHandler.js index f57856814..cb8195978 100644 --- a/test/e2e/utils/SortedWindowHandler.js +++ b/test/e2e/utils/SortedWindowHandler.js @@ -25,8 +25,28 @@ class SortedWindowHandler { */ windowHandles(callback) { this.client.windowHandles((result) => { - this.handles = this.handles.filter((handle) => result.value.includes(handle)); - const remaining = result.value.filter((handle) => !this.handles.includes(handle)); + if (Array.isArray(result.value)) { + this.handles = this.handles.filter((handle) => { + for (let i = 0; i < result.value.length; i++) { + if (result.value[i] === handle) { + return true; + } + } + + return false; + }); + } else { + this.handles = []; + } + const remaining = result.value.filter((handle) => { + for (let i = 0; i < this.handles.length; i++) { + if (this.handles[i] === handle) { + return false; + } + } + + return true; + }); if (remaining.length === 1) { this.handles.push(remaining[0]); } From 0e01d40aa7b2429d4860eee9ab7b118ab1fccbc9 Mon Sep 17 00:00:00 2001 From: Chi Vinh Le Date: Mon, 18 Dec 2017 19:01:43 +0100 Subject: [PATCH 2/3] Fix sign in on profile tab --- client/coral-framework/hocs/withQuery.js | 24 +++++++++++++------ .../containers/ProfileContainer.js | 2 +- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/client/coral-framework/hocs/withQuery.js b/client/coral-framework/hocs/withQuery.js index 280191f89..15ec62a47 100644 --- a/client/coral-framework/hocs/withQuery.js +++ b/client/coral-framework/hocs/withQuery.js @@ -49,8 +49,9 @@ export default (document, config = {}) => hoistStatics((WrappedComponent) => { memoized = null; resolvedDocument = null; lastNetworkStatus = null; - data = null; name = ''; + apolloData = null; + data = null; // Pending subscription data. subscriptionQueue = []; @@ -151,6 +152,7 @@ export default (document, config = {}) => hoistStatics((WrappedComponent) => { }; nextData(data) { + this.apolloData = data; this.emitWhenNeeded(data); // If data was previously set, we update it in a immutable way. @@ -181,16 +183,24 @@ export default (document, config = {}) => hoistStatics((WrappedComponent) => { variables: data.variables, networkStatus: data.networkStatus, loading: data.loading, - startPolling: data.startPolling, - stopPolling: data.stopPolling, - refetch: data.refetch, - updateQuery: data.updateQuery, subscribeToMoreThrottled: this.subscribeToMoreThrottled, + startPolling: (...args) => { + return this.apolloData.startPolling(...args); + }, + stopPolling: (...args) => { + return this.apolloData.stopPolling(...args); + }, + updateQuery: (...args) => { + return this.apolloData.updateQuery(...args); + }, + refetch: (...args) => { + return this.apolloData.refetch(...args); + }, subscribeToMore: (stmArgs) => { const resolvedDocument = this.resolveDocument(stmArgs.document); // Resolve document fragments before passing it to `apollo-client`. - return data.subscribeToMore({ + return this.apolloData.subscribeToMore({ ...stmArgs, document: resolvedDocument, onError: (err) => { @@ -209,7 +219,7 @@ export default (document, config = {}) => hoistStatics((WrappedComponent) => { {variables: lmArgs.variables}); // Resolve document fragments before passing it to `apollo-client`. - return data.fetchMore({ + return this.apolloData.fetchMore({ ...lmArgs, query: resolvedDocument, }) diff --git a/client/coral-settings/containers/ProfileContainer.js b/client/coral-settings/containers/ProfileContainer.js index 1ad8b98c9..5b4f5f0ed 100644 --- a/client/coral-settings/containers/ProfileContainer.js +++ b/client/coral-settings/containers/ProfileContainer.js @@ -61,7 +61,7 @@ class ProfileContainer extends Component { return ; } - if (loading) { + if (loading || !me) { return ; } From 583ab0ff741cf96d6b7c820956d8401a4eef0fc9 Mon Sep 17 00:00:00 2001 From: Wyatt Johnson Date: Mon, 18 Dec 2017 12:42:58 -0700 Subject: [PATCH 3/3] disabling firefox,edge --- scripts/e2e-ci.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/e2e-ci.sh b/scripts/e2e-ci.sh index 3e9726340..b86edb319 100755 --- a/scripts/e2e-ci.sh +++ b/scripts/e2e-ci.sh @@ -8,7 +8,10 @@ E2E_MAX_RETRIES=${E2E_MAX_RETRIES:-1} # Safari >= 8 has issues connecting to browserstack-local. Safari < 8 is too old. # IE 64bit has issues with receiving keyboard input. Let's wait for them to fix it. -BROWSERS="chrome,firefox,edge" #ie safari + +# FIXME: disabled firefox,edge until fixing pass is done +# BROWSERS="chrome,firefox,edge" #ie safari +BROWSERS="chrome" if [[ "${CIRCLE_BRANCH}" == "master" && -n "$BROWSERSTACK_KEY" ]]; then echo Testing on browserstack