[CORL-409] Prevent users from ignoring staff members (#2355)

* Throw error if user tries to ignore a staff member

Throws a UserCannotBeIgnoredError if a user tries to ignore
a user who is a staff member. A staff member in this case is
considered anyone who has a role of staff, moderator, or admin.

CORL-409

* Prevent users from ignoring staff in the user info popover

Creates the staff roles in a constant next to the user model.
Uses this to add a computed property to the user resolver.

CORL-409

* Remove unnecessary async declaration from userIsStaff helper function

CORL-409

* Specify ignoreable on users in client test fixtures

Allows the tests to pass for the required computed property
of ignoreable that is computed by whether a user is a staff
member or not.

CORL-409

* Update more fixtures with ignoreable property on mocked users/commenters

CORL-409

* Consolidate ignore-able calculation into re-usable helper methods

Re-use the logic for whether a role is a staff member to
clearly define when a user is ignore-able or not across the
business logic.

CORL-409

* Set the ignoreable optimisticResponse on comment mutations

We have set the ignoreable value in the graphQL schema, so now
the optimisticResponses are looking for a default value to use
until the data result arrives. Put to false since the ignoreable
value is set on our author, we likely don't want to ignore ourselves.

CORL-409

src/core/server/models/user/constants.ts

@@ -0,0 +1,7 @@
+import { GQLUSER_ROLE } from "coral-server/graph/tenant/schema/__generated__/types";
+
+export const STAFF_ROLES = [
+  GQLUSER_ROLE.ADMIN,
+  GQLUSER_ROLE.MODERATOR,
+  GQLUSER_ROLE.STAFF,
+];

src/core/server/models/user/helpers.ts

@@ -0,0 +1,16 @@
+import { GQLUSER_ROLE } from "coral-server/graph/tenant/schema/__generated__/types";
+import { STAFF_ROLES } from "coral-server/models/user/constants";
+
+import { User } from ".";
+
+export function roleIsStaff(role: GQLUSER_ROLE) {
+  if (STAFF_ROLES.includes(role)) {
+    return true;
+  }
+
+  return false;
+}
+
+export function userIsStaff(user: User) {
+  return roleIsStaff(user.role);
+}

src/core/server/models/user/index.ts

@@ -25,17 +25,17 @@ import {
 } from "coral-server/graph/tenant/schema/__generated__/types";
 import { getLocalProfile, hasLocalProfile } from "coral-server/helpers/users";
 import logger from "coral-server/logger";
+import {
+  Connection,
+  ConnectionInput,
+  resolveConnection,
+} from "coral-server/models/helpers/connection";
 import {
   createConnectionOrderVariants,
   createIndexFactory,
 } from "coral-server/models/helpers/indexing";
 import Query from "coral-server/models/helpers/query";
 import { TenantResource } from "coral-server/models/tenant";
-import {
-  Connection,
-  ConnectionInput,
-  resolveConnection,
-} from "./helpers/connection";
 
 function collection(mongo: Db) {
   return mongo.collection<Readonly<User>>("users");