From 6966bb8d12a50e9b9973546e4ec1edfaae79fa65 Mon Sep 17 00:00:00 2001 From: Nick Funk Date: Fri, 31 Jul 2020 09:40:48 -0600 Subject: [PATCH] Replace positive/negative naming for success/error (#3058) CORL-1200 --- CSS_VARIABLES.md | 4 ++-- .../account/routes/download/Download/Sorry.tsx | 2 +- .../client/account/routes/email/Confirm/Sorry.tsx | 2 +- .../routes/notifications/Unsubscribe/Sorry.tsx | 2 +- .../notifications/Unsubscribe/UnsubscribeForm.tsx | 2 +- .../routes/password/Reset/ResetPasswordForm.tsx | 4 +--- .../client/account/routes/password/Reset/Sorry.tsx | 2 +- .../test/__snapshots__/confirmEmail.spec.tsx.snap | 2 +- .../test/__snapshots__/resetPassword.spec.tsx.snap | 2 +- .../unsubscribeNotifications.spec.tsx.snap | 2 +- .../test/__snapshots__/addEmailAddress.spec.tsx.snap | 4 ++-- .../test/__snapshots__/createPassword.spec.tsx.snap | 4 ++-- .../test/__snapshots__/createUsername.spec.tsx.snap | 4 ++-- .../auth/views/AddEmailAddress/AddEmailAddress.tsx | 2 +- .../auth/views/CreatePassword/CreatePassword.tsx | 2 +- .../auth/views/CreateUsername/CreateUsername.tsx | 2 +- .../auth/views/ForgotPassword/ForgotPasswordForm.tsx | 2 +- .../auth/views/LinkAccount/LinkAccountContainer.tsx | 2 +- src/core/client/auth/views/SignIn/SignIn.tsx | 2 +- .../client/auth/views/SignIn/SignInWithEmail.tsx | 2 +- .../views/SignIn/__snapshots__/SignIn.spec.tsx.snap | 2 +- .../client/auth/views/SignUp/SignUpWithEmail.tsx | 2 +- .../tabs/Comments/Comment/ReplyEditSubmitStatus.tsx | 2 +- .../ReportFlow/ReportCommentFormContainer.tsx | 2 +- .../stream/tabs/Comments/Stream/BannedInfo.tsx | 2 +- .../tabs/Comments/Stream/CommentForm/CommentForm.tsx | 6 +++--- .../StreamDeletionRequestCalloutContainer.tsx | 2 +- .../PostCommentForm/PostCommentRejectedMessage.tsx | 2 +- .../Comments/Stream/SuspendedInfo/SuspendedInfo.tsx | 2 +- .../Configure/AddMessage/AddMessageContainer.tsx | 2 +- .../tabs/Configure/AddMessage/AddMessageOpen.tsx | 4 ++-- .../Configure/ConfigureStream/ConfigureStream.tsx | 4 ++-- .../LiveUpdatesConfig/LiveUpdatesConfigContainer.tsx | 4 ++-- .../tabs/Configure/OpenOrCloseStream/CloseStream.tsx | 2 +- .../OpenOrCloseStream/OpenOrCloseStreamContainer.tsx | 4 ++-- .../stream/tabs/Configure/Q&A/QAConfigContainer.tsx | 4 ++-- .../DeletionRequestCalloutContainer.tsx | 2 +- .../Profile/MyComments/DownloadCommentsContainer.tsx | 4 ++-- .../Preferences/NotificationSettingsContainer.tsx | 4 ++-- .../Settings/ChangeEmail/ChangeEmailContainer.tsx | 4 ++-- .../stream/tabs/Profile/Settings/ChangePassword.tsx | 4 ++-- .../ChangeUsername/ChangeUsernameContainer.tsx | 4 ++-- .../DeleteAccount/DeleteAccountContainer.tsx | 2 +- .../Settings/DeleteAccount/Pages/ConfirmPage.tsx | 2 +- .../stream/__snapshots__/editComment.spec.tsx.snap | 4 ++-- .../stream/__snapshots__/reportComment.spec.tsx.snap | 4 ++-- .../__snapshots__/renderConfigure.spec.tsx.snap | 2 +- .../test/profile/__snapshots__/account.spec.tsx.snap | 2 +- src/core/client/ui/components/v3/Button/Button.css | 12 ++++++------ src/core/client/ui/components/v3/Button/Button.tsx | 6 +++--- src/core/client/ui/components/v3/CallOut/CallOut.css | 8 ++++---- src/core/client/ui/components/v3/CallOut/CallOut.tsx | 12 ++++++------ src/core/client/ui/theme/sharedVariables.ts | 4 ++-- 53 files changed, 87 insertions(+), 89 deletions(-) diff --git a/CSS_VARIABLES.md b/CSS_VARIABLES.md index 49cee7268..a4880285d 100644 --- a/CSS_VARIABLES.md +++ b/CSS_VARIABLES.md @@ -127,7 +127,7 @@ Color palette that is used for grey shades. #### palette-error -Color palette that is used for indicating something negative and is usually red. +Color palette that is used for indicating something is error red. `--palette-error-100: #FCE5D9; /* Before 6.3.0: --palette-error-lightest */` @@ -149,7 +149,7 @@ Color palette that is used for indicating something negative and is usually red. #### palette-success -Color palette that is used for indicating something positive and is usually green. +Color palette that is used for indicating something is success green. `--palette-success-100: #D8F9D5; /* Before 6.3.0: --palette-success-lightest */` diff --git a/src/core/client/account/routes/download/Download/Sorry.tsx b/src/core/client/account/routes/download/Download/Sorry.tsx index 826aa3f46..928e53162 100644 --- a/src/core/client/account/routes/download/Download/Sorry.tsx +++ b/src/core/client/account/routes/download/Download/Sorry.tsx @@ -7,7 +7,7 @@ import { CallOut } from "coral-ui/components/v3"; const Sorry: FunctionComponent = () => { return ( error} titleWeight="semiBold" title={ diff --git a/src/core/client/account/routes/email/Confirm/Sorry.tsx b/src/core/client/account/routes/email/Confirm/Sorry.tsx index af24f038e..3d4c5b165 100644 --- a/src/core/client/account/routes/email/Confirm/Sorry.tsx +++ b/src/core/client/account/routes/email/Confirm/Sorry.tsx @@ -16,7 +16,7 @@ const Sorry: React.FunctionComponent = ({ reason }) => {
Oops Sorry!
= ({ reason }) => {
Oops Sorry!
= ({ notifications. - {submitError && } + {submitError && }