From 735ecbcef3250344e25d40c68e08a32c243733a0 Mon Sep 17 00:00:00 2001 From: Wyatt Johnson Date: Fri, 23 Feb 2018 14:00:07 -0700 Subject: [PATCH] linting updates --- .eslintignore | 34 +------------------ plugins/talk-plugin-akismet/.eslintrc.json | 3 -- plugins/talk-plugin-auth/.eslintrc.json | 3 -- .../talk-plugin-author-menu/.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- .../talk-plugin-facebook-auth/.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- .../talk-plugin-flag-details/.eslintrc.json | 3 -- .../talk-plugin-google-auth/.eslintrc.json | 3 -- .../client/components/SignIn.js | 4 +-- .../client/components/SignUp.js | 4 +-- .../talk-plugin-ignore-user/.eslintrc.json | 3 -- plugins/talk-plugin-like/.eslintrc.json | 3 -- plugins/talk-plugin-love/.eslintrc.json | 3 -- .../talk-plugin-member-since/.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- plugins/talk-plugin-offtopic/.eslintrc.json | 3 -- plugins/talk-plugin-permalink/.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- .../talk-plugin-remember-sort/.eslintrc.json | 3 -- plugins/talk-plugin-respect/.eslintrc.json | 3 -- .../client/.eslintrc.json | 22 +----------- .../.eslintrc.json | 3 -- .../server/config.js | 4 ++- .../server/hooks.js | 29 ++++++++-------- .../.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- .../talk-plugin-sort-newest/.eslintrc.json | 3 -- .../talk-plugin-sort-oldest/.eslintrc.json | 3 -- plugins/talk-plugin-subscriber/.eslintrc.json | 4 --- .../talk-plugin-toxic-comments/.eslintrc.json | 3 -- .../.eslintrc.json | 3 -- 35 files changed, 22 insertions(+), 163 deletions(-) delete mode 100644 plugins/talk-plugin-akismet/.eslintrc.json delete mode 100644 plugins/talk-plugin-auth/.eslintrc.json delete mode 100644 plugins/talk-plugin-author-menu/.eslintrc.json delete mode 100644 plugins/talk-plugin-comment-content/.eslintrc.json delete mode 100644 plugins/talk-plugin-deep-reply-count/.eslintrc.json delete mode 100644 plugins/talk-plugin-facebook-auth/.eslintrc.json delete mode 100644 plugins/talk-plugin-featured-comments/.eslintrc.json delete mode 100644 plugins/talk-plugin-flag-details/.eslintrc.json delete mode 100644 plugins/talk-plugin-google-auth/.eslintrc.json delete mode 100644 plugins/talk-plugin-ignore-user/.eslintrc.json delete mode 100644 plugins/talk-plugin-like/.eslintrc.json delete mode 100644 plugins/talk-plugin-love/.eslintrc.json delete mode 100644 plugins/talk-plugin-member-since/.eslintrc.json delete mode 100644 plugins/talk-plugin-moderation-actions/.eslintrc.json delete mode 100644 plugins/talk-plugin-offtopic/.eslintrc.json delete mode 100644 plugins/talk-plugin-permalink/.eslintrc.json delete mode 100644 plugins/talk-plugin-profile-settings/.eslintrc.json delete mode 100644 plugins/talk-plugin-remember-sort/.eslintrc.json delete mode 100644 plugins/talk-plugin-respect/.eslintrc.json delete mode 100644 plugins/talk-plugin-slack-notifications/.eslintrc.json delete mode 100644 plugins/talk-plugin-sort-most-liked/.eslintrc.json delete mode 100644 plugins/talk-plugin-sort-most-loved/.eslintrc.json delete mode 100644 plugins/talk-plugin-sort-most-replied/.eslintrc.json delete mode 100644 plugins/talk-plugin-sort-most-respected/.eslintrc.json delete mode 100644 plugins/talk-plugin-sort-newest/.eslintrc.json delete mode 100644 plugins/talk-plugin-sort-oldest/.eslintrc.json delete mode 100644 plugins/talk-plugin-subscriber/.eslintrc.json delete mode 100644 plugins/talk-plugin-toxic-comments/.eslintrc.json delete mode 100644 plugins/talk-plugin-viewing-options/.eslintrc.json diff --git a/.eslintignore b/.eslintignore index ded9d13ad..ad58230e0 100644 --- a/.eslintignore +++ b/.eslintignore @@ -2,36 +2,4 @@ dist docs node_modules -plugins/* -public - -!plugins/talk-plugin-akismet -!plugins/talk-plugin-auth -!plugins/talk-plugin-author-menu -!plugins/talk-plugin-comment-content -!plugins/talk-plugin-deep-reply-count -!plugins/talk-plugin-facebook-auth -!plugins/talk-plugin-featured-comments -!plugins/talk-plugin-flag-details -!plugins/talk-plugin-ignore-user -!plugins/talk-plugin-like -!plugins/talk-plugin-love -!plugins/talk-plugin-member-since -!plugins/talk-plugin-mod -!plugins/talk-plugin-moderation-actions -!plugins/talk-plugin-offtopic -!plugins/talk-plugin-permalink -!plugins/talk-plugin-profile-settings -!plugins/talk-plugin-remember-sort -!plugins/talk-plugin-respect -!plugins/talk-plugin-rich-text -!plugins/talk-plugin-rich-text-pell -!plugins/talk-plugin-sort-most-liked -!plugins/talk-plugin-sort-most-loved -!plugins/talk-plugin-sort-most-replied -!plugins/talk-plugin-sort-most-respected -!plugins/talk-plugin-sort-newest -!plugins/talk-plugin-sort-oldest -!plugins/talk-plugin-subscriber -!plugins/talk-plugin-toxic-comments -!plugins/talk-plugin-viewing-options \ No newline at end of file +public \ No newline at end of file diff --git a/plugins/talk-plugin-akismet/.eslintrc.json b/plugins/talk-plugin-akismet/.eslintrc.json deleted file mode 100644 index 64e91163f..000000000 --- a/plugins/talk-plugin-akismet/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} \ No newline at end of file diff --git a/plugins/talk-plugin-auth/.eslintrc.json b/plugins/talk-plugin-auth/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-auth/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-author-menu/.eslintrc.json b/plugins/talk-plugin-author-menu/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-author-menu/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-comment-content/.eslintrc.json b/plugins/talk-plugin-comment-content/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-comment-content/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-deep-reply-count/.eslintrc.json b/plugins/talk-plugin-deep-reply-count/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-deep-reply-count/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-facebook-auth/.eslintrc.json b/plugins/talk-plugin-facebook-auth/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-facebook-auth/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-featured-comments/.eslintrc.json b/plugins/talk-plugin-featured-comments/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-featured-comments/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-flag-details/.eslintrc.json b/plugins/talk-plugin-flag-details/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-flag-details/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-google-auth/.eslintrc.json b/plugins/talk-plugin-google-auth/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-google-auth/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-google-auth/client/components/SignIn.js b/plugins/talk-plugin-google-auth/client/components/SignIn.js index 527d41238..a361cfe70 100644 --- a/plugins/talk-plugin-google-auth/client/components/SignIn.js +++ b/plugins/talk-plugin-google-auth/client/components/SignIn.js @@ -3,7 +3,5 @@ import GoogleButton from '../containers/GoogleButton'; import { t } from 'plugin-api/beta/client/services'; export default () => { - return ( - {t('talk-plugin-google-auth.sign_in')} - ); + return {t('talk-plugin-google-auth.sign_in')}; }; diff --git a/plugins/talk-plugin-google-auth/client/components/SignUp.js b/plugins/talk-plugin-google-auth/client/components/SignUp.js index 704cc3963..3193b02fb 100644 --- a/plugins/talk-plugin-google-auth/client/components/SignUp.js +++ b/plugins/talk-plugin-google-auth/client/components/SignUp.js @@ -3,7 +3,5 @@ import GoogleButton from '../containers/GoogleButton'; import { t } from 'plugin-api/beta/client/services'; export default () => { - return ( - {t('talk-plugin-google-auth.sign_up')} - ); + return {t('talk-plugin-google-auth.sign_up')}; }; diff --git a/plugins/talk-plugin-ignore-user/.eslintrc.json b/plugins/talk-plugin-ignore-user/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-ignore-user/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-like/.eslintrc.json b/plugins/talk-plugin-like/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-like/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-love/.eslintrc.json b/plugins/talk-plugin-love/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-love/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-member-since/.eslintrc.json b/plugins/talk-plugin-member-since/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-member-since/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-moderation-actions/.eslintrc.json b/plugins/talk-plugin-moderation-actions/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-moderation-actions/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-offtopic/.eslintrc.json b/plugins/talk-plugin-offtopic/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-offtopic/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-permalink/.eslintrc.json b/plugins/talk-plugin-permalink/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-permalink/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-profile-settings/.eslintrc.json b/plugins/talk-plugin-profile-settings/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-profile-settings/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-remember-sort/.eslintrc.json b/plugins/talk-plugin-remember-sort/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-remember-sort/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-respect/.eslintrc.json b/plugins/talk-plugin-respect/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-respect/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-rich-text-pell/client/.eslintrc.json b/plugins/talk-plugin-rich-text-pell/client/.eslintrc.json index 9fe56bd14..c8a6db18a 100644 --- a/plugins/talk-plugin-rich-text-pell/client/.eslintrc.json +++ b/plugins/talk-plugin-rich-text-pell/client/.eslintrc.json @@ -1,23 +1,3 @@ { - "env": { - "browser": true, - "es6": true, - "mocha": true - }, - "parserOptions": { - "sourceType": "module", - "ecmaFeatures": { - "experimentalObjectRestSpread": true, - "jsx": true - } - }, - "parser": "babel-eslint", - "plugins": [ - "react" - ], - "rules": { - "react/jsx-uses-react": "error", - "react/jsx-uses-vars": "error", - "no-console": ["warn", { "allow": ["warn", "error"] }] - } + "extends": "@coralproject/eslint-config-talk/client" } diff --git a/plugins/talk-plugin-slack-notifications/.eslintrc.json b/plugins/talk-plugin-slack-notifications/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-slack-notifications/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-slack-notifications/server/config.js b/plugins/talk-plugin-slack-notifications/server/config.js index 7571565b0..11f76f138 100644 --- a/plugins/talk-plugin-slack-notifications/server/config.js +++ b/plugins/talk-plugin-slack-notifications/server/config.js @@ -5,7 +5,9 @@ const config = { if (process.env.NODE_ENV !== 'test' && !config.SLACK_WEBHOOK_URL) { // TODO this error should point users to Talk's Slack app once that's in place - throw new Error('Please set the TALK_SLACK_WEBHOOK_URL environment variable to use the slack-notifications plugin.'); + throw new Error( + 'Please set the TALK_SLACK_WEBHOOK_URL environment variable to use the slack-notifications plugin.' + ); } module.exports = config; diff --git a/plugins/talk-plugin-slack-notifications/server/hooks.js b/plugins/talk-plugin-slack-notifications/server/hooks.js index bda9dc4f5..eac0c1be4 100644 --- a/plugins/talk-plugin-slack-notifications/server/hooks.js +++ b/plugins/talk-plugin-slack-notifications/server/hooks.js @@ -1,5 +1,5 @@ const fetch = require('node-fetch'); -const {SLACK_WEBHOOK_URL, SLACK_WEBHOOK_TIMEOUT} = require('./config'); +const { SLACK_WEBHOOK_URL, SLACK_WEBHOOK_TIMEOUT } = require('./config'); const debug = require('debug')('talk:plugin:slack-notifications'); // We don't add the hooks during _test_ as the Slack API is not available. @@ -10,14 +10,9 @@ if (process.env.NODE_ENV === 'test') { module.exports = { RootMutation: { createComment: { - async post(_, {input}, context, _info, result) { + async post(_, _, context, info, result) { debug(`Posting notification to Slack webhook: ${SLACK_WEBHOOK_URL}`); - const { - comment: { - body: text, - created_at: createdAt - } - } = result; + const { comment: { body: text, created_at: createdAt } } = result; const username = context.user.username; process.nextTick(async () => { const response = await fetch(SLACK_WEBHOOK_URL, { @@ -27,16 +22,22 @@ module.exports = { }, timeout: SLACK_WEBHOOK_TIMEOUT, body: JSON.stringify({ - attachments: [{ - text: text, - footer: `Comment by ${username}`, - ts: Math.floor(Date.parse(createdAt) / 1000), - }] + attachments: [ + { + text: text, + footer: `Comment by ${username}`, + ts: Math.floor(Date.parse(createdAt) / 1000), + }, + ], }), }); if (!response.ok) { const responseText = await response.text(); - console.trace(`Posting to Slack failed with HTTP code ${response.status} and body '${responseText}'`); + console.trace( + `Posting to Slack failed with HTTP code ${ + response.status + } and body '${responseText}'` + ); } }); return result; diff --git a/plugins/talk-plugin-sort-most-liked/.eslintrc.json b/plugins/talk-plugin-sort-most-liked/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-sort-most-liked/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-sort-most-loved/.eslintrc.json b/plugins/talk-plugin-sort-most-loved/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-sort-most-loved/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-sort-most-replied/.eslintrc.json b/plugins/talk-plugin-sort-most-replied/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-sort-most-replied/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-sort-most-respected/.eslintrc.json b/plugins/talk-plugin-sort-most-respected/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-sort-most-respected/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-sort-newest/.eslintrc.json b/plugins/talk-plugin-sort-newest/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-sort-newest/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-sort-oldest/.eslintrc.json b/plugins/talk-plugin-sort-oldest/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-sort-oldest/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-subscriber/.eslintrc.json b/plugins/talk-plugin-subscriber/.eslintrc.json deleted file mode 100644 index d7d291614..000000000 --- a/plugins/talk-plugin-subscriber/.eslintrc.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" - } - \ No newline at end of file diff --git a/plugins/talk-plugin-toxic-comments/.eslintrc.json b/plugins/talk-plugin-toxic-comments/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-toxic-comments/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -} diff --git a/plugins/talk-plugin-viewing-options/.eslintrc.json b/plugins/talk-plugin-viewing-options/.eslintrc.json deleted file mode 100644 index 78f7c2397..000000000 --- a/plugins/talk-plugin-viewing-options/.eslintrc.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "@coralproject/eslint-config-talk" -}