From 10cd53b40ba6065a83fdd2e1fef8bbf2a741ff61 Mon Sep 17 00:00:00 2001 From: gaba Date: Tue, 25 Apr 2017 14:28:37 -0500 Subject: [PATCH 1/3] Only shows the Loading component when there is no search value --- client/coral-admin/src/containers/Community/People.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/coral-admin/src/containers/Community/People.js b/client/coral-admin/src/containers/Community/People.js index 0011cd704..084e574fb 100644 --- a/client/coral-admin/src/containers/Community/People.js +++ b/client/coral-admin/src/containers/Community/People.js @@ -47,7 +47,7 @@ const People = ({isFetching, commenters, searchValue, onSearchChange, ...props})
- { isFetching && } + { isFetching && (searchValue === null) && } { hasResults ? Date: Wed, 26 Apr 2017 14:00:26 -0500 Subject: [PATCH 2/3] Removing the Loading all together. --- client/coral-admin/src/containers/Community/People.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/client/coral-admin/src/containers/Community/People.js b/client/coral-admin/src/containers/Community/People.js index 084e574fb..3fd486fb6 100644 --- a/client/coral-admin/src/containers/Community/People.js +++ b/client/coral-admin/src/containers/Community/People.js @@ -4,7 +4,6 @@ import translations from 'coral-admin/src/translations.json'; import styles from './Community.css'; import Table from './Table'; -import Loading from './Loading'; import {Pager, Icon} from 'coral-ui'; import EmptyCard from '../../components/EmptyCard'; @@ -47,7 +46,6 @@ const People = ({isFetching, commenters, searchValue, onSearchChange, ...props})
- { isFetching && (searchValue === null) && } { hasResults ?
Date: Wed, 26 Apr 2017 14:25:18 -0500 Subject: [PATCH 3/3] Remove isfetching all together. --- client/coral-admin/src/containers/Community/People.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/coral-admin/src/containers/Community/People.js b/client/coral-admin/src/containers/Community/People.js index 3fd486fb6..e375bac38 100644 --- a/client/coral-admin/src/containers/Community/People.js +++ b/client/coral-admin/src/containers/Community/People.js @@ -28,8 +28,8 @@ const tableHeaders = [ } ]; -const People = ({isFetching, commenters, searchValue, onSearchChange, ...props}) => { - const hasResults = !isFetching && !!commenters.length; +const People = ({commenters, searchValue, onSearchChange, ...props}) => { + const hasResults = !!commenters.length; return (