[next] Start a clean session when user logs in / out (#1853)

* Clear user session after login / logout

* Filename cases

* Improve type checking

* Apply suggestions

src/core/client/framework/mutations/SetAuthTokenMutation.spec.ts

@@ -1,7 +1,9 @@
 import { Environment, RecordSource } from "relay-runtime";
+import sinon from "sinon";
 
+import { TalkContext } from "talk-framework/lib/bootstrap";
 import { LOCAL_ID } from "talk-framework/lib/relay";
-import { createInMemoryStorage } from "talk-framework/lib/storage";
+import { createPromisifiedStorage } from "talk-framework/lib/storage";
 import { createRelayEnvironment } from "talk-framework/testHelpers";
 
 import { commit } from "./SetAuthTokenMutation";
@@ -15,21 +17,29 @@ beforeAll(() => {
   });
 });
 
-it("Sets auth token to localStorage", () => {
-  const context = {
-    localStorage: createInMemoryStorage(),
+it("Sets auth token to localStorage", async () => {
+  const clearSessionStub = sinon.stub();
+  const context: Partial<TalkContext> = {
+    localStorage: createPromisifiedStorage(),
+    clearSession: clearSessionStub,
   };
   const authToken = "auth token";
-  commit(environment, { authToken }, context as any);
+  await commit(environment, { authToken }, context as any);
   expect(source.get(LOCAL_ID)!.authToken).toEqual(authToken);
-  expect(context.localStorage.getItem("authToken")).toEqual(authToken);
+  await expect(context.localStorage!.getItem("authToken")).resolves.toEqual(
+    authToken
+  );
+  expect(clearSessionStub.calledOnce).toBe(true);
 });
 
-it("Removes auth token from localStorage", () => {
-  const context = {
-    localStorage: createInMemoryStorage(),
+it("Removes auth token from localStorage", async () => {
+  const clearSessionStub = sinon.stub();
+  const context: Partial<TalkContext> = {
+    localStorage: createPromisifiedStorage(),
+    clearSession: clearSessionStub,
   };
   localStorage.setItem("authToken", "tmp");
-  commit(environment, { authToken: null }, context as any);
-  expect(context.localStorage.getItem("authToken")).toBeNull();
+  await commit(environment, { authToken: null }, context as any);
+  await expect(context.localStorage!.getItem("authToken")).resolves.toBeNull();
+  expect(clearSessionStub.calledOnce).toBe(true);
 });

src/core/client/framework/mutations/SetAuthTokenMutation.ts

@@ -1,7 +1,10 @@
-import { commitLocalUpdate, Environment } from "relay-runtime";
+import { Environment } from "relay-runtime";
 
 import { TalkContext } from "talk-framework/lib/bootstrap";
-import { createMutationContainer } from "talk-framework/lib/relay";
+import {
+  commitLocalUpdatePromisified,
+  createMutationContainer,
+} from "talk-framework/lib/relay";
 import { LOCAL_ID } from "talk-framework/lib/relay/withLocalStateContainer";
 
 export interface SetAuthTokenInput {
@@ -13,27 +16,18 @@ export type SetAuthTokenMutation = (input: SetAuthTokenInput) => Promise<void>;
 export async function commit(
   environment: Environment,
   input: SetAuthTokenInput,
-  { localStorage }: TalkContext
+  { localStorage, clearSession }: TalkContext
 ) {
-  return commitLocalUpdate(environment, store => {
+  return await commitLocalUpdatePromisified(environment, async store => {
     const record = store.get(LOCAL_ID)!;
     record.setValue(input.authToken, "authToken");
     if (input.authToken) {
-      localStorage.setItem("authToken", input.authToken);
+      await localStorage.setItem("authToken", input.authToken);
     } else {
-      localStorage.removeItem("authToken");
+      await localStorage.removeItem("authToken");
     }
-    // Increment auth revision to indicate a change in auth state.
-    record.setValue(record.getValue("authRevision") + 1, "authRevision");
-
-    // Force gc to trigger.
-    environment
-      .retain({
-        dataID: "tmp",
-        node: { selections: [] },
-        variables: {},
-      })
-      .dispose();
+    // Clear current session, as we are starting a new one.
+    clearSession();
   });
 }