From af80d795ad2e7871723913f22e08d220bbac2d9b Mon Sep 17 00:00:00 2001
From: Chi Vinh Le <vinh@wikiwi.io>
Date: Thu, 8 Mar 2018 15:17:36 +0100
Subject: [PATCH] Only show digest options when having choice

---
 .../client/components/Settings.js             | 62 ++++++++++---------
 1 file changed, 34 insertions(+), 28 deletions(-)

diff --git a/plugins/talk-plugin-notifications/client/components/Settings.js b/plugins/talk-plugin-notifications/client/components/Settings.js
index 329f4d1c1..a5c3b4fcd 100644
--- a/plugins/talk-plugin-notifications/client/components/Settings.js
+++ b/plugins/talk-plugin-notifications/client/components/Settings.js
@@ -37,8 +37,15 @@ class Settings extends React.Component {
       onChangeDigestFrequency,
     } = this.props;
 
+    const slotProps = {
+      queryData: { root },
+      setTurnOffInputFragment: setTurnOffInputFragment,
+      updateNotificationSettings: updateNotificationSettings,
+      disabled: needEmailVerification,
+    };
+
     return (
-      <IfSlotIsNotEmpty slot="notificationSettings" queryData={{ root }}>
+      <IfSlotIsNotEmpty slot="notificationSettings" {...slotProps}>
         <div className={styles.root}>
           <h3>{t('talk-plugin-notifications.settings_title')}</h3>
           <div className={styles.bannerContainer}>
@@ -55,36 +62,35 @@ class Settings extends React.Component {
             <Slot
               className={styles.notifcationSettingsSlot}
               fill="notificationSettings"
-              queryData={{ root }}
               childFactory={this.childFactory}
-              setTurnOffInputFragment={setTurnOffInputFragment}
-              updateNotificationSettings={updateNotificationSettings}
-              disabled={needEmailVerification}
+              {...slotProps}
             />
           </div>
-          <div className={styles.digest}>
-            <h4
-              className={cn(styles.titleDigest, {
-                [styles.disabled]: disableDigest,
-              })}
-            >
-              {t('talk-plugin-notifications.digest_option')}
-            </h4>
-            <Dropdown
-              className={styles.digestDropDown}
-              value={digestFrequency}
-              onChange={onChangeDigestFrequency}
-              disabled={disableDigest}
-            >
-              {digestFrequencyValues.map(v => (
-                <Option
-                  value={v}
-                  key={v}
-                  label={t(`talk-plugin-notifications.digest_enum.${v}`)}
-                />
-              ))}
-            </Dropdown>
-          </div>
+          {digestFrequencyValues.length > 1 && (
+            <div className={styles.digest}>
+              <h4
+                className={cn(styles.titleDigest, {
+                  [styles.disabled]: disableDigest,
+                })}
+              >
+                {t('talk-plugin-notifications.digest_option')}
+              </h4>
+              <Dropdown
+                className={styles.digestDropDown}
+                value={digestFrequency}
+                onChange={onChangeDigestFrequency}
+                disabled={disableDigest}
+              >
+                {digestFrequencyValues.map(v => (
+                  <Option
+                    value={v}
+                    key={v}
+                    label={t(`talk-plugin-notifications.digest_enum.${v}`)}
+                  />
+                ))}
+              </Dropdown>
+            </div>
+          )}
           <BareButton
             className={styles.turnOffButton}
             onClick={turnOffAll}