Adding displayname editing and appropriate toggle.

test/routes/api/user/index.js

@@ -83,3 +83,82 @@ describe('/api/v1/users/:user_id/actions', () => {
     });
   });
 });
+
+describe('/api/v1/users/:user_id/username-enable', () => {
+  let mockUser;
+
+  beforeEach(() => SettingsService.init(settings).then(() => {
+    return UsersService.createLocalUser('ana@gmail.com', '123321123', 'Ana');
+  })
+  .then((user) => {
+    mockUser = user;
+  }));
+
+  describe('#post', () => {
+    it('it should enable a user to edit their username', () => {
+      return chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/username-enable`)
+        .set(passport.inject({id: '456', roles: ['ADMIN']}))
+        .then((res) => {
+          expect(res).to.have.status(204);
+        });
+    });
+  });
+});
+
+describe('/api/v1/account/displayname', () => {
+  let mockUser;
+
+  beforeEach(() => SettingsService.init(settings).then(() => {
+    return UsersService.createLocalUser('ana@gmail.com', '123321123', 'Ana');
+  })
+  .then((user) => {
+    mockUser = user;
+  }));
+
+  describe('#post', () => {
+    it('it should enable a user to edit their username if canEditName is enabled', () => {
+      return chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/username-enable`)
+        .set(passport.inject({id: '456', roles: ['ADMIN']}))
+        .then(() => chai.request(app)
+          .put('/api/v1/account/displayname')
+          .set(passport.inject({id: mockUser.id, roles: []}))
+          .send({displayName: 'MojoJojo'}))
+        .then((res) => {
+          expect(res).to.have.status(204);
+        });
+    });
+
+    it('it should return an error if the wrong user tries to edit a username', (done) => {
+      chai.request(app)
+        .post(`/api/v1/users/${mockUser.id}/username-enable`)
+        .set(passport.inject({id: '456', roles: ['ADMIN']}))
+        .then(() => chai.request(app)
+          .put('/api/v1/account/displayname')
+          .set(passport.inject({id: 'wrongid', roles: []}))
+          .send({displayName: 'MojoJojo'}))
+        .then(() => {
+          done(new Error('Exected Error'));
+        })
+        .catch((err) => {
+          expect(err).to.be.truthy;
+          done();
+        });
+    });
+
+    it('it should return an error when the user tries to edit their username if canEditName is disabled', (done) => {
+      chai.request(app)
+        .put('/api/v1/account/displayname')
+        .set(passport.inject({id: mockUser.id, roles: []}))
+        .send({username: 'MojoJojo'})
+        .then(() => {
+          done(new Error('Exected Error'));
+        })
+        .catch((err) => {
+          expect(err).to.be.truthy;
+          done();
+        });
+    });
+  });
+});

test/services/users.js

@@ -208,4 +208,56 @@ describe('services.UsersService', () => {
         });
     });
   });
+
+  describe('#toggleUsernameEdit', () => {
+    it('should toggle the canEditName field', () => {
+      return UsersService
+        .toggleUsernameEdit(mockUsers[0].id, true)
+        .then(() => UsersService.findById(mockUsers[0].id))
+        .then((user) => {
+          expect(user).to.have.property('canEditName', true);
+        });
+    });
+  });
+
+  describe('#editUsername', () => {
+    it('should let the user edit their username if the proper toggle is set', () => {
+      return UsersService
+        .toggleUsernameEdit(mockUsers[0].id, true)
+        .then(() => UsersService.editUsername(mockUsers[0].id, 'Jojo'))
+        .then(() => UsersService.findById(mockUsers[0].id))
+        .then((user) => {
+          expect(user).to.have.property('displayName', 'jojo');
+          expect(user).to.have.property('canEditName', false);
+        });
+    });
+
+    it('should return an error if canEditName is false', (done) => {
+      UsersService
+        .editUsername(mockUsers[0].id, 'Jojo')
+        .then(() => UsersService.findById(mockUsers[0].id))
+        .then(() => {
+          done(new Error('Error expected'));
+        })
+        .catch((err) => {
+          expect(err).to.be.truthy;
+          done();
+        });
+    });
+
+    it('should return an error if the username is already taken', (done) => {
+      UsersService
+      .toggleUsernameEdit(mockUsers[0].id, true)
+      .then(() => UsersService.editUsername(mockUsers[0].id, 'Marvel'))
+      .then(() => UsersService.findById(mockUsers[0].id))
+      .then(() => {
+        done(new Error('Error expected'));
+      })
+      .catch((err) => {
+        expect(err).to.be.truthy;
+        done();
+      });
+    });
+  });
+
 });