wassname/talk
1
0
Fork 0
mirror of https://github.com/wassname/talk.git synced 2026-08-11 11:27:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

rename Comments.comment to Comments.visible and allow slack task to load any comment regardless of visibility (#2855)

Browse Source 
Co-authored-by: Wyatt Johnson <accounts+github@wyattjoh.ca>
This commit is contained in:
Tessa Thornton
2020-02-27 18:46:28 +00:00
committed by GitHub
co-authored by Wyatt Johnson
parent a059e70d05
commit c052d37a6f
4 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/server/graph/resolvers/Comment.ts
+2 -2
View File
@@ -40,7 +40,7 @@ export const maybeLoadOnlyID = (
// We want more than the ID! Get the comment!
// TODO: (wyattjoh) if the parent and the parents (containing the parent) are requested, the parent comment is retrieved from the database twice. Investigate ways of reducing i/o.
return ctx.loaders.Comments.comment.load(id);
return ctx.loaders.Comments.visible.load(id);
};
export const Comment: GQLCommentTypeResolver<comment.Comment> = {
@@ -77,7 +77,7 @@ export const Comment: GQLCommentTypeResolver<comment.Comment> = {
return 0;
}
const children = await ctx.loaders.Comments.comment.loadMany(childIDs);
const children = await ctx.loaders.Comments.visible.loadMany(childIDs);
return children.reduce(
(sum: any, c: any) => (c && hasPublishedStatus(c) ? sum + 1 : sum),
0
src/core/server/graph/resolvers/CommentModerationAction.ts
+1 -1
View File
@@ -6,7 +6,7 @@ export const CommentModerationAction: GQLCommentModerationActionTypeResolver<
actions.CommentModerationAction
> = {
revision: async (action, input, ctx) => {
const comment = await ctx.loaders.Comments.comment.load(action.commentID);
const comment = await ctx.loaders.Comments.visible.load(action.commentID);
if (!comment) {
return null;
}
src/core/server/graph/resolvers/Query.ts
+1 -1
View File
@@ -14,7 +14,7 @@ export const Query: Required<GQLQueryTypeResolver<void>> = {
user: (source, args, ctx) => ctx.loaders.Users.user.load(args.id),
users: (source, args, ctx) => ctx.loaders.Users.connection(args),
comment: (source, { id }, ctx) =>
id ? ctx.loaders.Comments.comment.load(id) : null,
id ? ctx.loaders.Comments.visible.load(id) : null,
comments: (source, args, ctx) => ctx.loaders.Comments.forFilter(args),
settings: (source, args, ctx) => ctx.tenant,
viewer: (source, args, ctx) => ctx.user,