rename Comments.comment to Comments.visible and allow slack task to load any comment regardless of visibility (#2855)

Co-authored-by: Wyatt Johnson <accounts+github@wyattjoh.ca>
This commit is contained in:
Tessa Thornton
2020-02-27 18:46:28 +00:00
committed by GitHub
co-authored by Wyatt Johnson
parent a059e70d05
commit c052d37a6f
4 changed files with 14 additions and 6 deletions
+2 -2
View File
@@ -40,7 +40,7 @@ export const maybeLoadOnlyID = (
// We want more than the ID! Get the comment!
// TODO: (wyattjoh) if the parent and the parents (containing the parent) are requested, the parent comment is retrieved from the database twice. Investigate ways of reducing i/o.
return ctx.loaders.Comments.comment.load(id);
return ctx.loaders.Comments.visible.load(id);
};
export const Comment: GQLCommentTypeResolver<comment.Comment> = {
@@ -77,7 +77,7 @@ export const Comment: GQLCommentTypeResolver<comment.Comment> = {
return 0;
}
const children = await ctx.loaders.Comments.comment.loadMany(childIDs);
const children = await ctx.loaders.Comments.visible.loadMany(childIDs);
return children.reduce(
(sum: any, c: any) => (c && hasPublishedStatus(c) ? sum + 1 : sum),
0