From 083b8638e89a397d0557fb6cfb845a4360776029 Mon Sep 17 00:00:00 2001 From: Nicolas Ferro Date: Thu, 22 Feb 2018 19:17:26 -0300 Subject: [PATCH 1/3] issue #1022 - quiet logs on production mode --- webpack.config.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/webpack.config.js b/webpack.config.js index 193ebe65e..3a9ffcde5 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -214,12 +214,14 @@ if (process.env.NODE_ENV === 'production') { toplevel: false, typeofs: false, unused: false, - // Switch off all types of compression except those needed to convince // react-devtools that we're using a production build conditionals: true, dead_code: true, evaluate: true, + // Remove warnings + discard any console.* functions + warnings: false, + drop_console: true }, mangle: true, }, @@ -353,7 +355,7 @@ module.exports = [ if (targets.length === 0) { throw new Error( `target plugin ${ - plugin.name + plugin.name } has no targets in it's target folder ${folder}` ); } From 855e972bec4b3a9f89c65ae8d1cbbd4a569e8e3c Mon Sep 17 00:00:00 2001 From: Nicolas Ferro Date: Thu, 22 Feb 2018 19:34:33 -0300 Subject: [PATCH 2/3] fix pre-commit errors --- webpack.config.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webpack.config.js b/webpack.config.js index 3a9ffcde5..428bbf117 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -221,7 +221,7 @@ if (process.env.NODE_ENV === 'production') { evaluate: true, // Remove warnings + discard any console.* functions warnings: false, - drop_console: true + drop_console: true, }, mangle: true, }, @@ -355,7 +355,7 @@ module.exports = [ if (targets.length === 0) { throw new Error( `target plugin ${ - plugin.name + plugin.name } has no targets in it's target folder ${folder}` ); } From e33ccb57b6cb5b81dd7c84b03959378222a26bf6 Mon Sep 17 00:00:00 2001 From: Nicolas Ferro Date: Thu, 22 Feb 2018 21:00:55 -0300 Subject: [PATCH 3/3] invoke console warning through window to prevent from being discarded on prod --- client/coral-embed/src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/coral-embed/src/index.js b/client/coral-embed/src/index.js index 43bd3202e..2f456c4e2 100644 --- a/client/coral-embed/src/index.js +++ b/client/coral-embed/src/index.js @@ -16,7 +16,7 @@ function parseAssetURL() { // Try to get the url from the canonical tag on the page. return document.querySelector('link[rel="canonical"]').href; } catch (e) { - console.warn( + window.console.warn( 'This page does not include a canonical link tag. Talk has inferred this asset_url from the window object. Query params have been stripped, which may cause a single thread to be present across multiple pages.' );