From fd7114ab2ac976107319347d97177166a8e03a13 Mon Sep 17 00:00:00 2001 From: Harrison Reid Date: Thu, 18 Oct 2018 21:06:00 +1100 Subject: [PATCH 1/2] Keep question box visible when comment stream is closed --- .../src/tabs/stream/components/Stream.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/client/coral-embed-stream/src/tabs/stream/components/Stream.js b/client/coral-embed-stream/src/tabs/stream/components/Stream.js index b097f3d57..f430bd7b4 100644 --- a/client/coral-embed-stream/src/tabs/stream/components/Stream.js +++ b/client/coral-embed-stream/src/tabs/stream/components/Stream.js @@ -305,6 +305,14 @@ class Stream extends React.Component { ) : ( )} + {questionBoxEnable && ( + + + + )} )} From 130dc578b3d0a9ff5b4b8b028cd5d8172a92019a Mon Sep 17 00:00:00 2001 From: Harrison Reid Date: Thu, 18 Oct 2018 21:25:36 +1100 Subject: [PATCH 2/2] Refactor Stream component, move QuestionBox render logic into seperate fn --- .../src/tabs/stream/components/Stream.js | 41 ++++++++++--------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/client/coral-embed-stream/src/tabs/stream/components/Stream.js b/client/coral-embed-stream/src/tabs/stream/components/Stream.js index f430bd7b4..73b4fbcfd 100644 --- a/client/coral-embed-stream/src/tabs/stream/components/Stream.js +++ b/client/coral-embed-stream/src/tabs/stream/components/Stream.js @@ -206,15 +206,30 @@ class Stream extends React.Component { ); } + renderQuestionBox() { + const { + root, + asset, + asset: { + settings: { questionBoxEnable, questionBoxContent, questionBoxIcon }, + }, + } = this.props; + const slotPassthrough = { root, asset }; + if (questionBoxEnable) { + return ( + + + + ); + } + } + render() { const { root, appendItemArray, asset, - asset: { - comment: highlightedComment, - settings: { questionBoxEnable }, - }, + asset: { comment: highlightedComment }, postComment, notify, updateItem, @@ -260,14 +275,7 @@ class Stream extends React.Component { content={asset.settings.infoBoxContent} enable={asset.settings.infoBoxEnable} /> - {questionBoxEnable && ( - - - - )} + {this.renderQuestionBox()} {!banned && temporarilySuspended && ( @@ -305,14 +313,7 @@ class Stream extends React.Component { ) : ( )} - {questionBoxEnable && ( - - - - )} + {this.renderQuestionBox()} )}