From c41b3c27bab70e0ac6b906eefb2d6eaab3d45ad1 Mon Sep 17 00:00:00 2001 From: A Lawliet Date: Thu, 22 Jun 2017 10:29:41 -0400 Subject: [PATCH] Prevent unnecessary render - no need to clear search if already empty, just close dropdown --- .../src/routes/Moderation/containers/StorySearch.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/client/coral-admin/src/routes/Moderation/containers/StorySearch.js b/client/coral-admin/src/routes/Moderation/containers/StorySearch.js index d9c3b2ef1..d5a0ad243 100644 --- a/client/coral-admin/src/routes/Moderation/containers/StorySearch.js +++ b/client/coral-admin/src/routes/Moderation/containers/StorySearch.js @@ -3,6 +3,7 @@ import {compose, gql} from 'react-apollo'; import StorySearch from '../components/StorySearch'; import {withRouter} from 'react-router'; import withQuery from 'coral-framework/hocs/withQuery'; +import {isEmpty} from 'lodash'; class StorySearchContainer extends React.Component { constructor(props) { @@ -24,7 +25,9 @@ class StorySearchContainer extends React.Component { } clearAndCloseSearch = () => { - this.clearSearch(); + if (!isEmpty(this.state.searchValue)) { + this.clearSearch(); + } this.props.closeSearch(); }