feat: moved some useful tools to common

src/core/client/embed/StreamEmbed.ts

@@ -1,6 +1,9 @@
 import { EventEmitter2 } from "eventemitter2";
 import qs from "query-string";
 
+import ensureNoEndSlash from "talk-common/utils/ensureNoEndSlash";
+import urls from "talk-framework/helpers/urls";
+
 import {
   Decorator,
   withAutoHeight,
@@ -15,13 +18,6 @@ import PymControl, {
   defaultPymControlFactory,
   PymControlFactory,
 } from "./PymControl";
-import { ensureNoEndSlash } from "./utils";
-
-// This is importing the url helper from the framework using a relative path
-// import because the ts paths are not configured to use the framework for this
-// target.
-// TODO: (wyattjoh) replace with import from framework when we include it in the config.
-import urls from "../framework/helpers/urls";
 
 export interface StreamEmbedConfig {
   storyID?: string;

src/core/client/embed/tsconfig.json

@@ -3,7 +3,11 @@
   "compilerOptions": {
     "lib": ["dom", "es5"],
     "types": ["jest", "node"],
-    "paths": {}
+    "baseUrl": "./",
+    "paths": {
+      "talk-common/*": ["../../common/*"],
+      "talk-framework/*": ["../framework/*"]
+    }
   },
   "include": [
     "./**/*",

src/core/client/embed/utils/ensureEndSlash.spec.ts

@@ -1,11 +0,0 @@
-import ensureEndSlash from "./ensureEndSlash";
-
-it("should add slash to the end", () => {
-  const path = ensureEndSlash("/test");
-  expect(path).toBe("/test/");
-});
-
-it("should not add slash to the end if it's already there", () => {
-  const path = ensureEndSlash("/test/");
-  expect(path).toBe("/test/");
-});

src/core/client/embed/utils/ensureEndSlash.ts

@@ -1,3 +0,0 @@
-export default function ensureEndSlash(p: string) {
-  return p.match(/\/$/) ? p : `${p}/`;
-}

src/core/client/embed/utils/ensureNoEndSlash.spec.ts

@@ -1,11 +0,0 @@
-import ensureNoEndSlash from "./ensureNoEndSlash";
-
-it("should remove the slash from the end", () => {
-  const path = ensureNoEndSlash("/test/");
-  expect(path).toBe("/test");
-});
-
-it("should not change a string if there is no ending slash", () => {
-  const path = ensureNoEndSlash("/test");
-  expect(path).toBe("/test");
-});

src/core/client/embed/utils/ensureNoEndSlash.ts

@@ -1,3 +0,0 @@
-export default function ensureEndSlash(p: string) {
-  return p.replace(/\/$/, "");
-}

src/core/client/embed/utils/index.ts

@@ -1,6 +1,4 @@
 export { default as buildURL } from "./buildURL";
-export { default as ensureEndSlash } from "./ensureEndSlash";
-export { default as ensureNoEndSlash } from "./ensureNoEndSlash";
 export { default as startsWith } from "./startsWith";
 export { default as prefixStorage } from "./prefixStorage";
 export { default as parseHashQuery } from "./parseHashQuery";