From cbf33b29fb94241034a4f77dc49f0e94d04d7d33 Mon Sep 17 00:00:00 2001 From: Wyatt Johnson Date: Thu, 22 Feb 2018 17:18:42 -0700 Subject: [PATCH] fixed permission bug --- graph/resolvers/root_query.js | 3 +++ graph/resolvers/util.js | 6 +----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/graph/resolvers/root_query.js b/graph/resolvers/root_query.js index 4447646f1..23fdef288 100644 --- a/graph/resolvers/root_query.js +++ b/graph/resolvers/root_query.js @@ -91,6 +91,9 @@ decorateWithPermissionCheck( if (user && user.id === id) { return true; } + + // We don't return false because we want to fallthrough to the permission + // check if the custom check fails. } ); diff --git a/graph/resolvers/util.js b/graph/resolvers/util.js index 67a4b805d..cec2a71dd 100644 --- a/graph/resolvers/util.js +++ b/graph/resolvers/util.js @@ -88,11 +88,7 @@ const wrapCheckPermissions = ( wrapCheck( typeResolver, field, - (obj, args, ctx) => { - if (checkPermissions(ctx, permissions)) { - return false; - } - }, + (obj, args, ctx) => !checkPermissions(ctx, permissions), skipFieldResolver );