From ccaa744a7832c986e039d6f5e773971bd3b11012 Mon Sep 17 00:00:00 2001 From: StephanieDClark Date: Wed, 28 Jun 2017 14:26:41 -0700 Subject: [PATCH 01/14] Updates to tab classes --- client/coral-ui/components/Tab.js | 2 +- client/coral-ui/components/TabBar.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/coral-ui/components/Tab.js b/client/coral-ui/components/Tab.js index cc2ee82d7..492c35cbe 100644 --- a/client/coral-ui/components/Tab.js +++ b/client/coral-ui/components/Tab.js @@ -4,7 +4,7 @@ import styles from './Tab.css'; export default ({children, tabId, active, onTabClick, cStyle = 'base', ...props}) => (
  • onTabClick(tabId)} > {children} diff --git a/client/coral-ui/components/TabBar.js b/client/coral-ui/components/TabBar.js index 7809dee11..08f466ffc 100644 --- a/client/coral-ui/components/TabBar.js +++ b/client/coral-ui/components/TabBar.js @@ -17,7 +17,7 @@ class TabBar extends React.Component { const {children, activeTab, cStyle = 'base'} = this.props; return (
    -
      +
        {React.Children.toArray(children) .filter((child) => !child.props.restricted) .map((child, tabId) => From ab84436a782a5ccb219313e0765607dacc9c82ea Mon Sep 17 00:00:00 2001 From: Wyatt Johnson Date: Wed, 28 Jun 2017 15:32:53 -0600 Subject: [PATCH 02/14] Update plugins.default.json --- plugins.default.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins.default.json b/plugins.default.json index 7b2115421..3bc2e41bf 100644 --- a/plugins.default.json +++ b/plugins.default.json @@ -12,6 +12,7 @@ "coral-plugin-auth", "coral-plugin-offtopic", "coral-plugin-viewing-options", - "coral-plugin-comment-content" + "coral-plugin-comment-content", + "talk-plugin-permalink" ] } From 06ebd9ccc52ee78703a7975dd9a07232d04dd717 Mon Sep 17 00:00:00 2001 From: Kim Gardner Date: Thu, 29 Jun 2017 12:15:00 +0100 Subject: [PATCH 03/14] Bump version to 2.2.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 2834a3e3a..95e4515fc 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "talk", - "version": "2.1.0", + "version": "2.2.0", "description": "A better commenting experience from Mozilla, The New York Times, and the Washington Post. https://coralproject.net", "main": "app.js", "scripts": { From 87f8ed401f169167e86d0db73ce80a53ed138193 Mon Sep 17 00:00:00 2001 From: Belen Curcio Date: Thu, 29 Jun 2017 10:18:40 -0300 Subject: [PATCH 04/14] Using CommentId by queryParam --- client/coral-embed/src/index.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/client/coral-embed/src/index.js b/client/coral-embed/src/index.js index 82eea8ef7..3f3c63ba3 100644 --- a/client/coral-embed/src/index.js +++ b/client/coral-embed/src/index.js @@ -190,7 +190,10 @@ Talk.render = function(el, opts) { // Compose the query to send down to the Talk API so it knows what to load. let query = {}; - query.comment_id = window.location.hash.slice(1); + let urlParams = new URLSearchParams(window.location.search); + + query.comment_id = urlParams.get('commentId'); + query.asset_id = opts.asset_id; query.asset_url = opts.asset_url; From 0312530b86e25699c1388454e3c77a8a761824ba Mon Sep 17 00:00:00 2001 From: Belen Curcio Date: Thu, 29 Jun 2017 10:20:33 -0300 Subject: [PATCH 05/14] Modifying permalink plugin --- .../talk-plugin-permalink/client/components/PermalinkButton.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/talk-plugin-permalink/client/components/PermalinkButton.js b/plugins/talk-plugin-permalink/client/components/PermalinkButton.js index 68406472e..fc8561bdc 100644 --- a/plugins/talk-plugin-permalink/client/components/PermalinkButton.js +++ b/plugins/talk-plugin-permalink/client/components/PermalinkButton.js @@ -83,7 +83,7 @@ export default class PermalinkButton extends React.Component { className={cn(styles.input, `${name}-copy-field`)} type='text' ref={(input) => this.permalinkInput = input} - defaultValue={`${asset.url}#${this.props.commentId}`} + defaultValue={`${asset.url}?commentId=${this.props.commentId}`} />