From e7ab0b27f986e7749f26ddaf386bf330a2c0b8ec Mon Sep 17 00:00:00 2001 From: Wyatt Johnson Date: Fri, 4 Oct 2019 19:53:14 +0000 Subject: [PATCH] fix: fixed looping effect (#2626) --- src/core/client/admin/routes/Moderate/Moderate.tsx | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/core/client/admin/routes/Moderate/Moderate.tsx b/src/core/client/admin/routes/Moderate/Moderate.tsx index 652a7f6bb..9ff64d236 100644 --- a/src/core/client/admin/routes/Moderate/Moderate.tsx +++ b/src/core/client/admin/routes/Moderate/Moderate.tsx @@ -37,18 +37,19 @@ const Moderate: FunctionComponent = ({ const closeModal = useCallback(() => { setShowHotkeysModal(false); }, []); - const toggleModal = useCallback(() => { - setShowHotkeysModal(!showHotkeysModal); - }, [showHotkeysModal]); useEffect(() => { + const toggleModal = () => { + setShowHotkeysModal(was => !was); + }; + // Attach the modal toggle when the GUIDE button is pressed. key(HOTKEYS.GUIDE, toggleModal); return () => { // Detach the modal toggle if we have to rebind it. key.unbind(HOTKEYS.GUIDE); }; - }, [toggleModal]); + }, []); return (