From f53db233ce9ba6371533dcf236482ed832275e29 Mon Sep 17 00:00:00 2001 From: Nick Funk Date: Wed, 8 Jan 2020 11:06:16 -0700 Subject: [PATCH] [CORL-829] Bump line-height on select fields (#2779) * Bump line-height on select to account for hanging font characters Prevents characters like "g" or "j" being cut off at the bottom of the select. CORL-829 * Create new tall line height Use it for the select boxes to allow for dangling characters like 'g' and 'j'. CORL-829 --- src/core/client/ui/components/v2/SelectField/SelectField.css | 2 +- src/core/client/ui/theme/variables2.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/client/ui/components/v2/SelectField/SelectField.css b/src/core/client/ui/components/v2/SelectField/SelectField.css index 86048ce38..21ac58d6e 100644 --- a/src/core/client/ui/components/v2/SelectField/SelectField.css +++ b/src/core/client/ui/components/v2/SelectField/SelectField.css @@ -25,7 +25,7 @@ font-family: var(--v2-font-family-primary); font-weight: var(--v2-font-weight-primary-regular); font-size: var(--v2-font-size-3); - line-height: var(--v2-line-height-reset); + line-height: var(--v2-line-height-tall); appearance: none; outline: none; color: var(--v2-palette-input-value); diff --git a/src/core/client/ui/theme/variables2.ts b/src/core/client/ui/theme/variables2.ts index e6a1dc026..2baf219ed 100644 --- a/src/core/client/ui/theme/variables2.ts +++ b/src/core/client/ui/theme/variables2.ts @@ -277,6 +277,7 @@ const variables2 = { bodyShort: 1.3, reset: 1, title: 1.15, + tall: 1.3, }, fontSize: { 1: "0.75rem",