From cd4594f320acbb494f2da0447434ed447ee5f615 Mon Sep 17 00:00:00 2001 From: Shan Carter Date: Tue, 21 Nov 2017 14:51:35 -0800 Subject: [PATCH] Fixing NaN !== NaN problem in d-slider.js --- src/ui/d-slider.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ui/d-slider.js b/src/ui/d-slider.js index 1cdc3d5..66630e3 100644 --- a/src/ui/d-slider.js +++ b/src/ui/d-slider.js @@ -181,6 +181,7 @@ export class Slider extends T(HTMLElement) { static get observedAttributes() {return ['min', 'max', 'value', 'step', 'ticks', 'origin', 'tickValues', 'tickLabels']; } attributeChangedCallback(attr, oldValue, newValue) { + if (isNaN(newValue) || newValue === undefined || newValue === null) return; if (attr == 'min') { this.min = +newValue; this.setAttribute('aria-valuemin', this.min); @@ -194,7 +195,7 @@ export class Slider extends T(HTMLElement) { } if (attr == 'origin') { this.origin = +newValue; - this.update(this.value); + // this.update(this.value); } if (attr == 'step') { if (newValue > 0) {