Responding to feedback

Thanks @vsiao!
This commit is contained in:
Phips Peter
2015-01-29 14:39:09 -08:00
parent 429c0c5c7d
commit 03f12b0f66
5 changed files with 15 additions and 8 deletions
+4 -1
View File
@@ -6,6 +6,9 @@
/// <reference path="../node/node.d.ts"/>
declare module "gulp-if" {
function gulpIf(condition: boolean, stream: NodeJS.ReadWriteStream, elseStream?: NodeJS.ReadWriteStream): NodeJS.ReadWriteStream;
function gulpIf(
condition: boolean,
stream: NodeJS.ReadWriteStream,
elseStream?: NodeJS.ReadWriteStream): NodeJS.ReadWriteStream;
export = gulpIf;
}
+1 -1
View File
@@ -10,7 +10,7 @@ declare module "gulp-istanbul" {
module GulpIstanbul {
export function hookRequire(): NodeJS.ReadWriteStream;
export function summarizeCoverage(opts?: {coverageVariable: string}): Coverage;
export function summarizeCoverage(opts?: {coverageVariable?: string}): Coverage;
export function writeReports(opts?: ReportOptions): NodeJS.ReadWriteStream;
interface Options {
+8 -4
View File
@@ -6,15 +6,19 @@
/// <reference path="../node/node.d.ts"/>
declare module "gulp-rename" {
interface Options {
interface ParsedPath {
dirname?: string;
basename?: string;
prefix?: string;
suffix?: string;
extname?: string;
}
interface Options extends ParsedPath {
prefix?: string;
suffix?: string;
}
function rename(name: string): NodeJS.ReadWriteStream;
function rename(callback: (path: Options) => any): NodeJS.ReadWriteStream;
function rename(callback: (path: ParsedPath) => any): NodeJS.ReadWriteStream;
function rename(opts: Options): NodeJS.ReadWriteStream;
export = rename;
}
+1 -1
View File
@@ -7,7 +7,7 @@
declare module "gulp-replace" {
interface Options {
skipBinary: boolean;
skipBinary?: boolean;
}
function replace(pattern: string, replacement: string, opts?: Options): NodeJS.ReadWriteStream;
+1 -1
View File
@@ -13,7 +13,7 @@ declare module "gulp-tslint" {
module GulpTsLint {
interface Options {
configuration?: Object;
configuration?: {};
rulesDirectory?: string;
emitError?: boolean;
}