wassname/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/wassname/DefinitelyTyped.git synced 2026-09-09 11:13:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed wrong action creators type

Browse Source 
Using some of the redux-router action creators like pushState :
```
import { pushState } from 'redux-router';

export function saveEngagementAsVisibleSuccess(goTo) {
	return function(dispatch) {
		dispatch(pushState(null, goTo));
	}
}
```
Throws the following error:
```
Error TS2349: Cannot invoke an expression whose type lacks a call signature.

```
The redux-router [source code](https://github.com/acdlite/redux-router/blob/master/src/actionCreators.js#L46-L63) declare those as functions not objects:
```
export function historyAPI(method) {
  return (...args) => ({
    type: HISTORY_API,
    payload: {
      method,
      args
    }
  });
}

export const pushState = historyAPI('pushState');
export const push = historyAPI('push');
export const replaceState = historyAPI('replaceState');
export const replace = historyAPI('replace');
export const setState = historyAPI('setState');
export const go = historyAPI('go');
export const goBack = historyAPI('goBack');
export const goForward = historyAPI('goForward');
```
So I have update the types from `__ReduxRouter.ReduxRouterAction` to `__ReduxRouter.historyAPI`:
```
export const pushState: __ReduxRouter.historyAPI;
export const pushState: __ReduxRouter.historyAPI;
export const push: __ReduxRouter.historyAPI;
export const replaceState: __ReduxRouter.historyAPI;
export const replace: __ReduxRouter.historyAPI;
export const setState: __ReduxRouter.historyAPI;
export const go: __ReduxRouter.historyAPI;
export const goBack: __ReduxRouter.historyAPI;
export const goForward: __ReduxRouter.historyAPI;
```
This commit is contained in:
Remo H. Jansen
2016-02-17 17:47:49 +00:00
parent aefd814615
commit 0997ad0603
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
redux-router/redux-router.d.ts
Vendored
+9 -9
View File
@@ -34,7 +34,7 @@ declare namespace __ReduxRouter {
export function routerDidChange(state: any): ReduxRouterAction;
export function initRoutes(routes: any): ReduxRouterAction;
export function replaceRoutes(routes: any): ReduxRouterAction;
export function historyAPI(method: any): ReduxRouterAction;
export function historyAPI(method: any): (...args: any[]) => ReduxRouterAction;
}
declare module "redux-router/lib/routerStateReducer" {
@@ -59,14 +59,14 @@ declare module "redux-router/lib/actionCreators" {
export const initRoutes: typeof __ReduxRouter.initRoutes;
export const replaceRoutes: typeof __ReduxRouter.replaceRoutes;
export const historyAPI: typeof __ReduxRouter.historyAPI;
export const pushState: __ReduxRouter.ReduxRouterAction;
export const push: __ReduxRouter.ReduxRouterAction;
export const replaceState: __ReduxRouter.ReduxRouterAction;
export const replace: __ReduxRouter.ReduxRouterAction;
export const setState: __ReduxRouter.ReduxRouterAction;
export const go: __ReduxRouter.ReduxRouterAction;
export const goBack: __ReduxRouter.ReduxRouterAction;
export const goForward: __ReduxRouter.ReduxRouterAction;
export const pushState: __ReduxRouter.historyAPI;
export const push: __ReduxRouter.historyAPI;
export const replaceState: __ReduxRouter.historyAPI;
export const replace: __ReduxRouter.historyAPI;
export const setState: __ReduxRouter.historyAPI;
export const go: __ReduxRouter.historyAPI;
export const goBack: __ReduxRouter.historyAPI;
export const goForward: __ReduxRouter.historyAPI;
}
declare module "redux-router" {