Fix _().flatten() - remove non-existent methods, small type improvement

Previously type was too specific, and thereby often wrong. It's now less
specific, but never wrong.
This commit is contained in:
Tim Perry
2015-07-01 14:58:39 +01:00
parent 37c7620008
commit 36f2158f0c
2 changed files with 7 additions and 42 deletions
+3 -2
View File
@@ -247,9 +247,10 @@ result = <Array<number>>_.flatten([1, [2], [[3]]], true);
result = <Array<number>>_.flatten<number>([1, [2], [3, [[4]]]], true);
result = <Array<number|boolean>>_.flatten<number|boolean>([1, [2], [3, [[false]]]], true);
result = <_.LoDashArrayWrapper<number>>_([1, [2], [3, [[4]]]]).flatten();
result = <_.LoDashArrayWrapper<number>>_([[1, 2], [3, 4], 5, 6]).flatten();
result = <_.LoDashArrayWrapper<number|Array<Array<number>>>>_([1, [2], [3, [[4]]]]).flatten();
result = <_.LoDashArrayWrapper<number>>_([1, [2], [3, [[4]]]]).flatten(true);
result = <_.LoDashArrayWrapper<string>>_(stoogesQuotes).flatten('quotes');
result = <number>_.indexOf([1, 2, 3, 1, 2, 3], 2);
result = <number>_.indexOf([1, 2, 3, 1, 2, 3], 2, 3);
+4 -40
View File
@@ -795,50 +795,14 @@ declare module _ {
interface LoDashArrayWrapper<T> {
/**
* @see _.flatten
**/
flatten<Flat>(isShallow?: boolean): LoDashArrayWrapper<Flat>;
* @see _.flatten
**/
flatten<T>(): LoDashArrayWrapper<any>;
/**
* @see _.flatten
**/
flatten<Flat>(
isShallow: boolean,
callback: ListIterator<T, Flat>,
thisArg?: any): LoDashArrayWrapper<Flat>;
/**
* @see _.flatten
**/
flatten<Flat>(
callback: ListIterator<T, Flat>,
thisArg?: any): LoDashArrayWrapper<Flat>;
/**
* @see _.flatten
**/
flatten<Flat>(
isShallow: boolean,
pluckValue: string): LoDashArrayWrapper<Flat>;
/**
* @see _.flatten
**/
flatten<Flat>(
pluckValue: string): LoDashArrayWrapper<Flat>;
/**
* @see _.flatten
**/
flatten<Flat, W>(
isShallow: boolean,
whereValue: W): LoDashArrayWrapper<Flat>;
/**
* @see _.flatten
**/
flatten<Flat, W>(
whereValue: W): LoDashArrayWrapper<Flat>;
flatten<T>(isShallow: boolean): LoDashArrayWrapper<any>;
}
//_.indexOf