wassname/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/wassname/DefinitelyTyped.git synced 2026-09-09 11:13:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8697 from chbrown/pg-connect-cb-done-arg

Browse Source 
pg.connect(...) callback done argument to signal client removal from pool
This commit is contained in:
Masahiro Wakame
2016-03-26 23:05:30 +09:00
parent 30bba8884d d2a5819d31
commit c9ae6ec37f
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pg/pg-tests.ts
+5 -2
View File
@@ -12,10 +12,13 @@ pg.connect(conString, (err, client, done) => {
return console.error("Error fetching client from pool", err);
}
client.query("SELECT $1::int AS number", ["1"], (err, result) => {
done();
if (err) {
done(err);
return console.error("Error running query", err);
}
else {
done();
}
console.log(result.rows[0]["number"]);
return null;
});
@@ -37,4 +40,4 @@ client.connect((err) => {
return null;
});
return null;
});
});
pg/pg.d.ts
Vendored
+2 -2
View File
@@ -9,8 +9,8 @@ declare module "pg" {
import events = require("events");
import stream = require("stream");
export function connect(connection: string, callback: (err: Error, client: Client, done: () => void) => void): void;
export function connect(config: ClientConfig, callback: (err: Error, client: Client, done: () => void) => void): void;
export function connect(connection: string, callback: (err: Error, client: Client, done: (err?: any) => void) => void): void;
export function connect(config: ClientConfig, callback: (err: Error, client: Client, done: (err?: any) => void) => void): void;
export function end(): void;
export interface ConnectionConfig {