Add remove() to ionic.modal.IonicModalController

Per api: http://ionicframework.com/docs/api/controller/ionicModal/

note the note in the ionic source code:

"Be sure to call [remove()](#remove) when you are done with each modal
 to clean it up and avoid memory leaks."

https://github.com/driftyco/ionic/blob/af1bfef327e685585244c6051c4d38b98aa6c62a/js/angular/service/modal.js#L87
This commit is contained in:
Arthur Cinader
2015-12-17 12:00:03 -08:00
parent 78ba6e4154
commit f05f79fd58
2 changed files with 2 additions and 0 deletions
+1
View File
@@ -149,6 +149,7 @@ class IonicTestController {
ionicModalController.initialize(modalOptions);
ionicModalController.show().then(() => console.log("shown modal"))
ionicModalController.hide().then(() => console.log("hid modal"))
ionicModalController.remove().then(() => console.log("removed modal"))
var isShown: boolean = ionicModalController.isShown();
this.$ionicModal.fromTemplateUrl("templateUrl", modalOptions)
+1
View File
@@ -174,6 +174,7 @@ declare module ionic {
initialize(options: IonicModalOptions): void;
show(): ng.IPromise<void>;
hide(): ng.IPromise<void>;
remove(): ng.IPromise<void>;
isShown(): boolean;
}