release 9.4

Close #8

Changelog.md

@@ -1,5 +1,12 @@
 # Changelog
 
+**9.4**
+- postgresql: upgrade to 9.4
+
+**9.1-2**
+- use the official postgresql apt repo
+- feature: automatic data migration on upgrade
+
 **9.1-1**
 - upgrade to sameersbn/ubuntu:20141001, fixes shellshock
 - support creation of users and databases at launch (`docker run`)

Dockerfile

@@ -1,8 +1,11 @@
-FROM sameersbn/ubuntu:12.04.20141001
+FROM sameersbn/ubuntu:14.04.20150120
 MAINTAINER sameer@damagehead.com
 
-RUN apt-get update \
- && apt-get install -y postgresql postgresql-client pwgen \
+ENV PG_VERSION 9.4
+RUN wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - \
+ && echo 'deb http://apt.postgresql.org/pub/repos/apt/ trusty-pgdg main' > /etc/apt/sources.list.d/pgdg.list \
+ && apt-get update \
+ && apt-get install -y postgresql-${PG_VERSION} postgresql-client-${PG_VERSION} pwgen \
  && rm -rf /var/lib/postgresql \
  && rm -rf /var/lib/apt/lists/* # 20141001
 

LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2014 Sameer Naik
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

README.md

@@ -2,6 +2,7 @@
 
 - [Introduction](#introduction)
 - [Changelog](Changelog.md)
+- [Contributing](#contributing)
 - [Reporting Issues](#reporting-issues)
 - [Installation](#installation)
 - [Quick Start](#quick-start)
@@ -16,6 +17,14 @@
 
 Dockerfile to build a PostgreSQL container image which can be linked to other containers.
 
+# Contributing
+
+If you find this image useful here's how you can help:
+
+- Send a Pull Request with your awesome new features and bug fixes
+- Help new users with [Issues](https://github.com/sameersbn/docker-postgresql/issues) they may encounter
+- Send me a tip via [Bitcoin](https://www.coinbase.com/sameersbn) or using [Gratipay](https://gratipay.com/sameersbn/)
+
 # Reporting Issues
 
 Docker is a relatively new project and is active being developed and tested by a thriving community of developers and testers and every release of docker features many enhancements and bugfixes.
@@ -49,7 +58,7 @@ In your issue report please make sure you provide the following information:
 Pull the latest version of the image from the docker index. This is the recommended method of installation as it is easier to update image in the future. These builds are performed by the **Docker Trusted Build** service.
 
 ```bash
-docker pull sameersbn/postgresql:latest
+docker pull sameersbn/postgresql:9.4
 ```
 
 Alternately you can build the image yourself.
@@ -65,14 +74,14 @@ docker build -t="$USER/postgresql" .
 Run the postgresql image
 
 ```bash
-docker run --name postgresql -d sameersbn/postgresql:latest
+docker run --name postgresql -d sameersbn/postgresql:9.4
 ```
 
 The simplest way to login to the postgresql container as the administrative `postgres` user is to use the `--volumes-from` docker option to connect to the postgresql server over the unix socket.
 
 ```bash
 docker run -it --rm --volumes-from=postgresql \
-  sameersbn/postgresql sudo -u postgres -H psql
+  sameersbn/postgresql:9.4 sudo -u postgres -H psql
 ```
 
 Alternately you can fetch the password set for the `postgres` user from the container logs.
@@ -108,7 +117,7 @@ To create a new user you should specify the `DB_USER` and `DB_PASS` variables. T
 ```bash
 docker run --name postgresql -d \
   -e 'DB_USER=dbuser' -e 'DB_PASS=dbpass' \
-  sameersbn/postgresql:latest
+  sameersbn/postgresql:9.4
 ```
 
 **NOTE**
@@ -119,17 +128,24 @@ Similarly, you can also create a new database by specifying the database name in
 
 ```bash
 docker run --name postgresql -d \
-  -e 'DB_NAME=dbname' sameersbn/postgresql:latest
+  -e 'DB_NAME=dbname' sameersbn/postgresql:9.4
 ```
 
-If the `DB_USER` and `DB_PASS` variables are also specified while creating the database, then the user is granted access to the database.
+You may also specify a comma separated list of database names in the `DB_NAME` variable. The following command creates two new databases named *dbname1* and *dbname2 (p.s. this feature is only available in releases greater than 9.4)*
+
+```bash
+docker run --name postgresql -d \
+-e 'DB_NAME=dbname1,dbname2' sameersbn/postgresql:latest
+```
+
+If the `DB_USER` and `DB_PASS` variables are also specified while creating the database, then the user is granted access to the database(s).
 
 For example,
 
 ```bash
 docker run --name postgresql -d \
   -e 'DB_USER=dbuser' -e 'DB_PASS=dbpass' -e 'DB_NAME=dbname' \
-  sameersbn/postgresql:latest
+  sameersbn/postgresql:9.4
 ```
 
 , will create a user *dbuser* with the password *dbpass*. It will also create a database named *dbname* and the *dbuser* user will have full access to the *dbname* database.
@@ -151,16 +167,16 @@ The updated run command looks like this.
 
 ```bash
 docker run --name postgresql -d \
-  -v /opt/postgresql/data:/var/lib/postgresql sameersbn/postgresql:latest
+  -v /opt/postgresql/data:/var/lib/postgresql sameersbn/postgresql:9.4
 ```
 
 This will make sure that the data stored in the database is not lost when the image is stopped and started again.
 
 ## Securing the server
 
-By default a randomly generated password is assigned for the postgres user. The password is stored in a file named `pwpass` in the data store and is printed in the logs.
+By default a randomly generated password is assigned for the postgres user. The password is stored in a file named `pwfile` in the data store and is printed in the logs.
 
-If you dont want this password to be displayed in the logs, then please note down the password listed in `/opt/postgresql/data/pwpass` and then delete the file.
+If you dont want this password to be displayed in the logs, then please note down the password listed in `/opt/postgresql/data/pwfile` and then delete the file.
 
 ```bash
 cat /opt/postgresql/data/pwfile
@@ -176,11 +192,17 @@ psql -U postgres -h $(docker inspect --format {{.NetworkSettings.IPAddress}} pos
 
 # Shell Access
 
-For debugging and maintenance purposes you may want access the container shell. Since the container does not allow interactive login over the SSH protocol, you can use the [nsenter](http://man7.org/linux/man-pages/man1/nsenter.1.html) linux tool (part of the util-linux package) to access the container shell.
+For debugging and maintenance purposes you may want access the containers shell. If you are using docker version `1.3.0` or higher you can access a running containers shell using `docker exec` command.
+
+```bash
+docker exec -it postgresql bash
+```
+
+If you are using an older version of docker, you can use the [nsenter](http://man7.org/linux/man-pages/man1/nsenter.1.html) linux tool (part of the util-linux package) to access the container shell.
 
 Some linux distros (e.g. ubuntu) use older versions of the util-linux which do not include the `nsenter` tool. To get around this @jpetazzo has created a nice docker image that allows you to install the `nsenter` utility and a helper script named `docker-enter` on these distros.
 
-To install the nsenter tool on your host execute the following command.
+To install `nsenter` execute the following command on your host,
 
 ```bash
 docker run --rm -v /usr/local/bin:/target jpetazzo/nsenter
@@ -194,8 +216,6 @@ sudo docker-enter postgresql
 
 For more information refer https://github.com/jpetazzo/nsenter
 
-Another tool named `nsinit` can also be used for the same purpose. Please refer https://jpetazzo.github.io/2014/03/23/lxc-attach-nsinit-nsenter-docker-0-9/ for more information.
-
 # Upgrading
 
 To upgrade to newer releases, simply follow this 3 step upgrade procedure.
@@ -209,11 +229,11 @@ docker stop postgresql
 - **Step 2**: Update the docker image.
 
 ```bash
-docker pull sameersbn/postgresql:latest
+docker pull sameersbn/postgresql:9.4
 ```
 
 - **Step 3**: Start the image
 
 ```bash
-docker run --name postgresql -d [OPTIONS] sameersbn/postgresql:latest
+docker run --name postgresql -d [OPTIONS] sameersbn/postgresql:9.4
 ```

VERSION

@@ -1 +1 @@
-9.1
+9.4

start

@@ -1,21 +1,21 @@
 #!/bin/bash
 set -e
 
-PG_VERSION="9.1"
+PG_HOME="/var/lib/postgresql"
 PG_CONFDIR="/etc/postgresql/${PG_VERSION}/main"
 PG_BINDIR="/usr/lib/postgresql/${PG_VERSION}/bin"
-PG_DATADIR="/var/lib/postgresql/${PG_VERSION}/main"
+PG_DATADIR="${PG_HOME}/${PG_VERSION}/main"
 
 DB_NAME=${DB_NAME:-}
 DB_USER=${DB_USER:-}
 DB_PASS=${DB_PASS:-}
 
-# fix permissions and ownership of /var/lib/postgresql
-mkdir -p -m 0700 /var/lib/postgresql
-chown -R postgres:postgres /var/lib/postgresql
+# fix permissions and ownership of ${PG_HOME}
+mkdir -p -m 0700 ${PG_HOME}
+chown -R postgres:postgres ${PG_HOME}
 
 # fix permissions and ownership of /run/postgresql
-mkdir -p -m 0755 /run/postgresql
+mkdir -p -m 0755 /run/postgresql /run/postgresql/${PG_VERSION}-main.pg_stat_tmp
 chown -R postgres:postgres /run/postgresql
 chmod g+s /run/postgresql
 
@@ -32,18 +32,51 @@ cat >> ${PG_CONFDIR}/pg_hba.conf <<EOF
 host    all             all             0.0.0.0/0               md5
 EOF
 
+cd ${PG_HOME}
+
 # initialize PostgreSQL data directory
 if [ ! -d ${PG_DATADIR} ]; then
+  # check if we need to perform data migration
+  PG_OLD_VERSION=$(find ${PG_HOME}/[0-9].[0-9]/main -maxdepth 1 -name PG_VERSION | sort -r | head -n1 | cut -d'/' -f5)
+
+  if [ ! -f "${PG_HOME}/pwfile" ]; then
+    PG_PASSWORD=$(pwgen -c -n -1 14)
+    echo "${PG_PASSWORD}" > ${PG_HOME}/pwfile
+  fi
+
   echo "Initializing database..."
-  PG_PASSWORD=$(pwgen -c -n -1 14)
-  echo "${PG_PASSWORD}" > /var/lib/postgresql/pwfile
   sudo -u postgres -H "${PG_BINDIR}/initdb" \
-    --pgdata="${PG_DATADIR}" --pwfile=/var/lib/postgresql/pwfile \
+    --pgdata="${PG_DATADIR}" --pwfile=${PG_HOME}/pwfile \
     --username=postgres --encoding=unicode --auth=trust >/dev/null
 fi
 
-if [ -f /var/lib/postgresql/pwfile ]; then
-  PG_PASSWORD=$(cat /var/lib/postgresql/pwfile)
+if [ -n "${PG_OLD_VERSION}" ]; then
+  echo "Migrating postgresql ${PG_OLD_VERSION} data..."
+  PG_OLD_CONFDIR="/etc/postgresql/${PG_OLD_VERSION}/main"
+  PG_OLD_BINDIR="/usr/lib/postgresql/${PG_OLD_VERSION}/bin"
+  PG_OLD_DATADIR="${PG_HOME}/${PG_OLD_VERSION}/main"
+
+  # backup ${PG_OLD_DATADIR} to avoid data loss
+  PG_BKP_SUFFIX=$(date +%Y%m%d%H%M%S)
+  echo "Backing up ${PG_OLD_DATADIR} to ${PG_OLD_DATADIR}.${PG_BKP_SUFFIX}..."
+  cp -a ${PG_OLD_DATADIR} ${PG_OLD_DATADIR}.${PG_BKP_SUFFIX}
+
+  echo "Installing postgresql-${PG_OLD_VERSION}..."
+  apt-get update
+  apt-get install postgresql-${PG_OLD_VERSION} postgresql-client-${PG_OLD_VERSION}
+  rm -rf /var/lib/apt/lists/*
+
+  # migrate ${PG_OLD_VERSION} data
+  echo "Migration in progress. This could take a while, please be patient..."
+  sudo -u postgres -H ${PG_BINDIR}/pg_upgrade \
+    -b ${PG_OLD_BINDIR} -B ${PG_BINDIR} \
+    -d ${PG_OLD_DATADIR} -D ${PG_DATADIR} \
+    -o "-c config_file=${PG_OLD_CONFDIR}/postgresql.conf" \
+    -O "-c config_file=${PG_CONFDIR}/postgresql.conf" >/dev/null
+fi
+
+if [ -f ${PG_HOME}/pwfile ]; then
+  PG_PASSWORD=$(cat ${PG_HOME}/pwfile)
   echo "|------------------------------------------------------------------|"
   echo "| PostgreSQL User: postgres, Password: ${PG_PASSWORD}              |"
   echo "|                                                                  |"
@@ -69,17 +102,19 @@ if [ -n "${DB_USER}" ]; then
 fi
 
 if [ -n "${DB_NAME}" ]; then
-  echo "Creating database \"${DB_NAME}\"..."
-  echo "CREATE DATABASE ${DB_NAME};" | \
-    sudo -u postgres -H ${PG_BINDIR}/postgres --single \
-      -D ${PG_DATADIR} -c config_file=${PG_CONFDIR}/postgresql.conf >/dev/null 2>&1
-
-  if [ -n "${DB_USER}" ]; then
-    echo "Granting access to database \"${DB_NAME}\" for user \"${DB_USER}\"..."
-    echo "GRANT ALL PRIVILEGES ON DATABASE ${DB_NAME} to ${DB_USER};" |
+  for db in $(awk -F',' '{for (i = 1 ; i <= NF ; i++) print $i}' <<< "${DB_NAME}"); do
+    echo "Creating database \"${db}\"..."
+    echo "CREATE DATABASE ${db};" | \
       sudo -u postgres -H ${PG_BINDIR}/postgres --single \
         -D ${PG_DATADIR} -c config_file=${PG_CONFDIR}/postgresql.conf >/dev/null 2>&1
-  fi
+
+    if [ -n "${DB_USER}" ]; then
+      echo "Granting access to database \"${db}\" for user \"${DB_USER}\"..."
+      echo "GRANT ALL PRIVILEGES ON DATABASE ${db} to ${DB_USER};" |
+        sudo -u postgres -H ${PG_BINDIR}/postgres --single \
+          -D ${PG_DATADIR} -c config_file=${PG_CONFDIR}/postgresql.conf >/dev/null 2>&1
+    fi
+  done
 fi
 
 echo "Starting PostgreSQL server..."